Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local themes override rotemplate #62

Closed
steffilazerte opened this issue Dec 13, 2021 · 3 comments
Closed

Local themes override rotemplate #62

steffilazerte opened this issue Dec 13, 2021 · 3 comments

Comments

@steffilazerte
Copy link

Back before weathercan was part of rOpenSci, I had a red theme for the package docs. This was overridden by the rOpenSci theme, so I ignored it but never removed the red theme. Now in the new theme, parts of that original red show through (https://docs.ropensci.org/weathercan/).

If this is just something I should fix on my end, I'll close the issue and deal with it 😁, but I thought I'd mention it in case it's undesirable behaviour from the template.

@maelle
Copy link
Contributor

maelle commented Dec 13, 2021

Thank you! We've been working on adding more locks as it's a regression indeed.

@jeroen
Copy link
Contributor

jeroen commented Dec 13, 2021

Thanks for reporting. This was fixed in #60 (we now ignore extra.css and extra.js when building the ropensci docs). Can you have a look at https://docs.ropensci.org/weathercan/ if everything looks OK now? (you may need to force-refresh in your browser to make sure you're seeing the latest version)

@steffilazerte
Copy link
Author

Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants