Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report removal, hotfix for CRAN #22

Merged
merged 4 commits into from
Apr 8, 2024
Merged

Report removal, hotfix for CRAN #22

merged 4 commits into from
Apr 8, 2024

Conversation

leonawicz
Copy link
Member

Removing old one-off functionality. This was originally intended to be expanded into something much broader than a single report but never got any traction and does not fit the scope of the rest of the package. It's broken now, so a quick fix is needed for CRAN. But I also don't see a reason to support a one-off non-API function that downloads a single specific Excel file from the EIA website. That doesn't need its own wrapper function in the package. I have left the source code in-place but commented it out and anything related to it.

This also happens to reduce package imports.

… doesn't fit the scope of the package to warrant further support.
@leonawicz leonawicz requested a review from mghoff April 8, 2024 14:39
NEWS.md Outdated
# eia 0.4.2

* Removed one-off, non-API, report download function that no longer works but also do not intend to support within the scope of the package.
* Removed related. no longer needed package imports.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you want a comma after the word "related"?

Copy link
Collaborator

@mghoff mghoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment in NEWS.md

@mghoff mghoff merged commit 31104ab into master Apr 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants