Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate nodes_only as per #308 #312

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Deprecate nodes_only as per #308 #312

merged 1 commit into from
Feb 8, 2023

Conversation

jmaspons
Copy link
Collaborator

@jmaspons jmaspons commented Feb 8, 2023 •
edited
Loading

FIX #308

@jmaspons jmaspons requested a review from mpadge February 8, 2023 11:55
mpadge
mpadge approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@mpadge mpadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

@mpadge mpadge merged commit 2f30538 into ropensci:main Feb 8, 2023
@jmaspons jmaspons deleted the deprecate_nodes_only branch February 8, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpadge mpadge mpadge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate `nodes_only in opq function
2 participants
@jmaspons @mpadge