From 0454833d3b478d0431038c37bf8bba56f6256d39 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Christoph=20Fr=C3=B6hlich?= Date: Mon, 18 Nov 2024 19:54:32 +0100 Subject: [PATCH] Touchup mecanum (#27) * Update release notes * Update maintainers * Update compile flags * Fix compiler errors --- doc/release_notes.rst | 4 ++++ mecanum_drive_controller/CMakeLists.txt | 4 +++- mecanum_drive_controller/package.xml | 14 ++++++++++---- .../test/test_mecanum_drive_controller.hpp | 4 ++-- 4 files changed, 19 insertions(+), 7 deletions(-) diff --git a/doc/release_notes.rst b/doc/release_notes.rst index b1db026df2..974bca880f 100644 --- a/doc/release_notes.rst +++ b/doc/release_notes.rst @@ -50,6 +50,10 @@ joint_trajectory_controller * Add the boolean parameter ``set_last_command_interface_value_as_state_on_activation``. When set to ``true``, the last command interface value is used as both the current state and the last commanded state upon activation. When set to ``false``, the current state is used for both (`#1231 `_). +mecanum_drive_controller +************************ +* 🚀 The mecanum_drive_controller was added 🎉 (`#512 `_). + pid_controller ************************ * 🚀 The PID controller was added 🎉 (`#434 `_). diff --git a/mecanum_drive_controller/CMakeLists.txt b/mecanum_drive_controller/CMakeLists.txt index 26065e7c89..48bac58fe7 100644 --- a/mecanum_drive_controller/CMakeLists.txt +++ b/mecanum_drive_controller/CMakeLists.txt @@ -2,7 +2,9 @@ cmake_minimum_required(VERSION 3.16) project(mecanum_drive_controller LANGUAGES CXX) if(CMAKE_CXX_COMPILER_ID MATCHES "(GNU|Clang)") - add_compile_options(-Wall -Wextra -Wpedantic) + add_compile_options(-Wall -Wextra -Wpedantic -Werror=conversion -Werror=unused-but-set-variable + -Werror=return-type -Werror=shadow -Werror=format -Werror=range-loop-construct + -Werror=missing-braces) endif() # find dependencies diff --git a/mecanum_drive_controller/package.xml b/mecanum_drive_controller/package.xml index fc6c03ad8b..97aadf4327 100644 --- a/mecanum_drive_controller/package.xml +++ b/mecanum_drive_controller/package.xml @@ -5,15 +5,21 @@ 0.0.0 Implementation of mecanum drive controller for 4 wheel drive. - Dr.-Ing. Denis Štogl + Bence Magyar - Giridhar Bukka + Denis Štogl + Christoph Froehlich + Sai Kishor Kothakota + + Apache License 2.0 + + https://control.ros.org + https://github.com/ros-controls/ros2_controllers/issues + https://github.com/ros-controls/ros2_controllers/ Dr.-Ing. Denis Štogl Giridhar Bukka - Apache License 2.0 - ament_cmake generate_parameter_library diff --git a/mecanum_drive_controller/test/test_mecanum_drive_controller.hpp b/mecanum_drive_controller/test/test_mecanum_drive_controller.hpp index 64a99f87d4..5f7cf36dc7 100644 --- a/mecanum_drive_controller/test/test_mecanum_drive_controller.hpp +++ b/mecanum_drive_controller/test/test_mecanum_drive_controller.hpp @@ -291,8 +291,8 @@ class MecanumDriveControllerFixture : public ::testing::Test // Controller-related parameters - std::array joint_state_values_ = {0.1, 0.1, 0.1, 0.1}; - std::array joint_command_values_ = {101.101, 101.101, 101.101, 101.101}; + std::array joint_state_values_ = {{0.1, 0.1, 0.1, 0.1}}; + std::array joint_command_values_ = {{101.101, 101.101, 101.101, 101.101}}; static constexpr double TEST_LINEAR_VELOCITY_X = 1.5; static constexpr double TEST_LINEAR_VELOCITY_y = 0.0;