Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upcoming Melodic release #467

Closed
bmagyar opened this issue Mar 9, 2020 · 5 comments
Closed

Upcoming Melodic release #467

bmagyar opened this issue Mar 9, 2020 · 5 comments
Assignees

Comments

@bmagyar
Copy link
Member

bmagyar commented Mar 9, 2020

Wishlist:

@ipa-mdl @matthew-reynolds & whoever else is reading this, please feel free to add your preferred issues/PR-s to be addressed here and we will try to prioritize.

@bmagyar bmagyar self-assigned this Mar 9, 2020
@callen5914
Copy link

Yes please document implement much better. It's lousy!

@bmagyar
Copy link
Member Author

bmagyar commented Mar 14, 2020

@callen5914 if there's a specific thing you have problems with we can try taking a look.

@callen5914
Copy link

@bmagyar I have some issues with implementing the Ackermann Steering Controller.

To be a little more specific:

  1. The Wiki states you need a YAML file with a minimal setup as follows.
mobile_base_controller:
  type: "ackermann_steering_controller/AckermannSteeringController"
  rear_wheel: 'rear_wheel_joint'
  front_steer: 'front_steer_joint'
  pose_covariance_diagonal: [0.001, 0.001, 1000000.0, 1000000.0, 1000000.0, 1000.0]
  twist_covariance_diagonal: [0.001, 0.001, 1000000.0, 1000000.0, 1000000.0, 1000.0]

So does it matter where this yaml file located. Do I need to copy and paste the header files and the cpp file to my package some where? On the wiki they say you can get the gazebo sim plugin from this really old cirkit-03. None of this makes any sense.

Cheers,

@ros-gy
Copy link

ros-gy commented Apr 3, 2020

If possible, it would be great to have some documentation on 4-wheel steering controller.
https://github.com/ros-controls/ros_controllers/blob/melodic-devel/four_wheel_steering_controller/src/four_wheel_steering_controller.cpp
Specifically, derivation or description of the equations for calculating wheel velocities/angles, and what the difference is between twist command block (line 375) vs 4ws command block (line 418).

@matthew-reynolds
Copy link
Member

@ros-gy I've split your request out to #566.

I think this issue has outlived its usefulness so I will close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants