Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting to ROS2? #15

Open
mathsten opened this issue Sep 18, 2019 · 3 comments
Open

Porting to ROS2? #15

mathsten opened this issue Sep 18, 2019 · 3 comments

Comments

@mathsten
Copy link

Hi! Has anyone tried vprn_client_ros with ROS2, specifically Dashing Diademata? Are there any plans to port it over?

@paulbovbel
Copy link
Member

No plans, but PRs are very welcome! I don't have a VRPN system to test with at the moment.

@zeroos
Copy link

zeroos commented Jun 17, 2020

Hey!

We've been using this project previously (shameless plug: https://youtu.be/atLhROLzsFo) with a ROS2<->ROS1 bridge and, although a bit quirky sometimes, it was working fine.

However, now, while working on a new project I've decided to give it a try and rewrite vrpn_client_ros to work with ROS2: https://github.com/zeroos/vrpn_client_ros. We're still working on our project, so we might find some bugs, but the code seems to be working.

Unfortunately, while rewriting I skipped and commented out parts related to:

  1. publishing TF, because we're not using it
  2. accel and twist data, because OptiTrack does not provide them

I also got rid of a feature that made it possible to define multiple sensors per tracker (I didn't really understand how it works).

I thought it might still be helpful for some people, so I wanted to create a pull request, but apparently it's not possible on Github to request a new branch: https://stackoverflow.com/a/11635252/540717 ).

Would you be interested in accepting these changes? I do have some time in the close future, so if you think that something is missing I could try to improve it a bit.

@paulbovbel
Copy link
Member

paulbovbel commented Jun 18, 2020

For sure, please do make a PR, I've spun up a foxy-devel branch.

@zeroos zeroos mentioned this issue Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants