Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simple_message: possibility for name clashes with defines (INT32, INT64, ..) #65

Open
gavanderhoorn opened this issue Jan 10, 2014 · 0 comments
Open

simple_message: possibility for name clashes with defines (INT32, INT64, ..) #65

gavanderhoorn opened this issue Jan 10, 2014 · 0 comments
Labels
bug enhancement

Comments

@gavanderhoorn
Copy link
Member

We should probably namespace all defines used in the simple_message package, as they are rather generically named right now. Especially INT32, INT64, ROS and LINUXSOCKETS have the potential to clash with defines from other headers / libraries.

I propose to prefix them with something like SIMPLE_MESSAGE_.

Now that we start looking into properly exporting those defines to users of the package as well, this could become a real issue.
Jmeyer1292 pushed a commit to Jmeyer1292/industrial_core that referenced this issue Feb 14, 2017
Merge pull request ros-industrial#65 from gomezc/renumber-Session1-Ex…
ce624c0 
…ercises

Renumber session1 exercises
@jdlangs jdlangs mentioned this issue Feb 21, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gavanderhoorn