Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fisheye distortion model definition #581

Closed
wants to merge 8 commits into from
Closed

Update fisheye distortion model definition #581

wants to merge 8 commits into from

Conversation

DavidTorresOcana
Copy link
Contributor

Update fisheye distortion model definition.

Update calibration tool distortion model for fisheye camera to be compatible with ros-perception/vision_opencv#306 and ros-perception/image_common#146 in as indicated in ros/common_msgs#151.

This was referenced Aug 2, 2020
Closed
Closed
@JWhitleyWork
Copy link
Collaborator

@DavidTorresOcana Are you testing these changes in Melodic or Noetic? I've just updated the base branch from melodic to noetic and it's preferred to apply the changes to the latest version and back-port if necessary rather than the other way around. additionally, has this been tested on physical hardware?

@DavidTorresOcana
Copy link
Contributor Author

@DavidTorresOcana Are you testing these changes in Melodic or Noetic? I've just updated the base branch from melodic to noetic and it's preferred to apply the changes to the latest version and back-port if necessary rather than the other way around. additionally, has this been tested on physical hardware?

These changes (#581 , #441 , ros-perception/vision_opencv#306 ) have been tested in melodic and real hardware.

I do not think this precise PR would have any conflict (though is thought to work with #441 , ros-perception/vision_opencv#306) when merging into noetic.
Not sure about #441 and ros-perception/vision_opencv#306.

I will test all these in noeticwhen I have access to HW again and re-target the PRs

Joshua Whitley and others added 8 commits August 23, 2020 14:29
@DavidTorresOcana
Updating CHANGELOGs for release.
7d90afa
@DavidTorresOcana
melodic-1.15.0
ceb95b0
@timonegk @DavidTorresOcana
adapt to OpenCV4 (ros-perception#537)
74cd40b
@soeroesg @DavidTorresOcana
fixes for fisheye calibration (ros-perception#542)
dc722b5 
* fix ros-perception#503:

set_cammodel of StereoCalibrator need to override the method of parent class

fix related to opencv/opencv#11085

unlike cv2.calibrate, the cv2.fisheye.calibrate method expects float64 points and in an array with an extra dimension. The same for cv2.stereoCalibrate vs cv2.fisheye.stereoCalibrate

* removed commented line;
trimmed whitespace at line endings
@JStech @DavidTorresOcana
Add ChArUco board target (ros-perception#548)
0b17920 
* wip

* detecting ChArUco board

* successful ChArUco calibration

* updated with review comments
@DavidTorresOcana
CI: Adding Github Actions workflow.
3d9f2ca
@DavidTorresOcana
Updating CI badge in README.
7723c5d
@DavidTorresOcana
Update fisheye distortion model definition
0e80a90
@DavidTorresOcana DavidTorresOcana force-pushed the fisheye_distortion_model branch from 157f90d to 0e80a90 Compare August 23, 2020 12:36
@DavidTorresOcana DavidTorresOcana changed the base branch from melodic to noetic August 23, 2020 12:36
@DavidTorresOcana DavidTorresOcana mentioned this pull request Aug 23, 2020
Merged
@DavidTorresOcana
Copy link
Contributor Author

Please do no merge this. This PR has been substituted with #592 retargeting noetic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@DavidTorresOcana @JWhitleyWork @timonegk @soeroesg @JStech