Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

joy_teleop parameter namespace #32

Open
JulianS-Uni opened this issue Feb 28, 2019 · 0 comments
Open

joy_teleop parameter namespace #32

JulianS-Uni opened this issue Feb 28, 2019 · 0 comments

Comments

@JulianS-Uni
Copy link

JulianS-Uni commented Feb 28, 2019

In your documentation to joy_teleop you say the node is looking for the teleop param in private space (~teleop).
But from tests and looking into your code you seem to look for teleop in relative space.
I think you can fix this by changing the doc on ros wiki or changing the code in /teleop_tools/joy_teleop/scripts/joy_teleop.py in line 40 from
teleop_cfg = rospy.get_param("teleop") to teleop_cfg = rospy.get_param("~teleop").
And in line 25 check for ~teleop instead of teleop.
When looking in private space for params, maybe it would be more convinient to drop the teleop param at all and look for the name of the node as param instead (with if not rospy.has_param(rospy.get_name()): and teleop_cfg=rospy.get_param(rospy.get_name())). The rest of the code could be unchanged i think. An example .yaml would look like this then:

move:
    type: topic
    message_type: geometry_msgs/Twist
    topic_name: cmd_vel
    axis_mappings:
      -
        axis: 1
        target: linear.x
        scale: 1.0
      -
        axis: 2
        target: angular.z
        scale: 1.0

...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant