Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROS2 Dashing] unnecessary warning at default use_sim_time parameter #39

Open
IanTheEngineer opened this issue Sep 20, 2019 · 2 comments

Comments

@IanTheEngineer
Copy link

IanTheEngineer commented Sep 20, 2019

@artivis - in both the source repo and ros-testing Debians on ROS Dashing, I receive this warning every time I launch the node:

[joy_teleop-2] [WARN] [joy_teleop]: parameter use_sim_time is not a dict

use_sim_time is a standard parameter supplied to every node at launch-time. If unset or set to False, the node should use system time, True to use sim_time.

Regardless of whether this node handles use_sim_time itself, it should handle the param more gracefully than throwing a warning in this codeblock:
https://github.com/ros-teleop/teleop_tools/blob/dashing-devel/joy_teleop/joy_teleop/joy_teleop.py#L75-L95

@artivis
Copy link
Contributor

artivis commented Dec 14, 2019

@bmagyar Wasn't this closed by #38 ?

@bmagyar
Copy link
Member

bmagyar commented Dec 15, 2019

Unfortunately it was caused by #38 , see the commit here adding the dict warning here: 37074a5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants