Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix include order for cpplint #192

Merged
merged 2 commits into from
Jan 12, 2022
Merged

Fix include order for cpplint #192

merged 2 commits into from
Jan 12, 2022

Conversation

jacobperron
Copy link
Contributor

@jacobperron jacobperron mentioned this pull request Jan 11, 2022
Merged
@jacobperron
Copy link
Contributor Author

The appveyor job has been failing since August 2020 (#164). Perhaps we should just remove it considering we have Windows coverage via ci.ros2.org?

gbiggs
gbiggs approved these changes Jan 12, 2022
View reviewed changes
Copy link

@gbiggs gbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gbiggs
Copy link

gbiggs commented Jan 12, 2022

CI:

  • Linux Build Status
  • Linux (aarch64) Build Status
  • Windows Build Status

@gbiggs
Copy link

gbiggs commented Jan 12, 2022

What is the Appveyor job supposed to do?

@jacobperron
Copy link
Contributor Author

What is the Appveyor job supposed to do?

Test the package on Windows, I suppose. It was added in 2015 (#28); though it doesn't predate ci.ros2.org, so maybe it was supposed to provide additional test coverage. @wjwwood I know it's ancient history, but do you know the origin story?

@jacobperron jacobperron merged commit 99c0d03 into ros2 Jan 12, 2022
@jacobperron jacobperron deleted the jacob/update_cpplint_fork branch January 12, 2022 22:24
@wjwwood
Copy link
Member

wjwwood commented Jan 12, 2022

Not sure, but it may have been just covering class_loader itself before we were running ci.ros2.org on everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbiggs gbiggs gbiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacobperron @gbiggs @wjwwood