Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle errors in parsing liveliness tokens #72

Closed
Yadunund opened this issue Dec 2, 2023 · 2 comments
Closed

Handle errors in parsing liveliness tokens #72

Yadunund opened this issue Dec 2, 2023 · 2 comments

Comments

@Yadunund
Copy link
Member

Yadunund commented Dec 2, 2023

Something to be discussed is how to best handle errors in liveliness token subscriptions. Right now, an error message will be printed but should the node continue to function if transport works? See #70 (comment)
@Yadunund Yadunund mentioned this issue Dec 2, 2023
Merged
@clalancette
Copy link
Collaborator

Personally I think that we should detect the errors, report them once, ignore it, and then continue on. That will help deal with the case of a malicious actor intentionally publishing bogus liveliness tokens.

@Yadunund
Copy link
Member Author

Yadunund commented Apr 6, 2024 •
edited
Loading

Handled in #103

@Yadunund Yadunund closed this as completed Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@clalancette @Yadunund