Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dirty role determination in UI #302

Open
roscisz opened this issue Nov 3, 2020 · 0 comments
Open

Dirty role determination in UI #302

roscisz opened this issue Nov 3, 2020 · 0 comments
Labels

Comments

@roscisz
Copy link
Owner

roscisz commented Nov 3, 2020

Initiated in #296:

in TheLogin.vue:

var role = object.user_claims.roles.length === 2 ? 'admin' : 'user'

If further down the road we'd ever want to add more roles, this could lead to some annoying to troubleshoot errors, when user with any two roles is treated as an admin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant