Skip to content
This repository has been archived by the owner on Jan 14, 2023. It is now read-only.

Fix: message_generation dependency for standard messages #12

Merged
merged 1 commit into from
May 9, 2017

Conversation

jubeira
Copy link

@jubeira jubeira commented May 6, 2017

This fix updates message_generation dependency to kinetic range in template to generate messages properly.

See rosjava/rosjava_mvn_repo#27 and rosjava/rosjava_mvn_repo#32.

For the record, I verified that messages are now generated with a dependency on message_generation from [0.3, 0.4) instead of [0.2, 0.3).

Example POM for a message generated with new template:

<?xml version="1.0" encoding="UTF-8"?>
<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns="http://maven.apache.org/POM/4.0.0"
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
  <modelVersion>4.0.0</modelVersion>
  <groupId>org.ros.rosjava_messages</groupId>
  <artifactId>geometry_msgs</artifactId>
  <version>1.11.9</version>
  <dependencies>
    <dependency>
      <groupId>org.ros.rosjava_bootstrap</groupId>
      <artifactId>message_generation</artifactId>
      <version>[0.3,0.4)</version>
      <scope>runtime</scope>
    </dependency>
    <dependency>
      <groupId>org.ros.rosjava_messages</groupId>
      <artifactId>std_msgs</artifactId>
      <version>0.5.10</version>
      <scope>runtime</scope>
    </dependency>
  </dependencies>
</project>

@jubeira
Copy link
Author

jubeira commented May 6, 2017

Note: perhaps the messages should be updated in mvn_repo with this fix to avoid conflicts when using maven as the issues specified above point out.

@adamantivm
Copy link
Contributor

Thank you very much, @jubeira . And yes, you're right, I will update the messages in the maven repo as soon as I get a chance.

@adamantivm adamantivm merged commit 29a3f68 into rosjava:kinetic May 9, 2017
@jubeira
Copy link
Author

jubeira commented May 9, 2017

👍 Thanks!
Perhaps this step should be written somewhere to take it into account next time... Having these values hardcoded in the code is somewhat difficult to maintain. Whenever a new release bumps the version, that value should be updated for consistency.

@jubeira jubeira deleted the fix/message_generation_kinetic branch May 9, 2017 14:39
@adamantivm
Copy link
Contributor

I agree @jubeira . I just added it to this doc that we used with @stonier last time around.

@adamantivm
Copy link
Contributor

PR submitted: rosjava/rosjava_mvn_repo#36

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants