Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated constant which will be removed in HA Core 2025.1[Issue]: #195

Open
MC-Repair-Milano opened this issue Jan 3, 2024 · 33 comments

Comments

@MC-Repair-Milano
Copy link

MC-Repair-Milano commented Jan 3, 2024

HVAC_MODE_OFF was used from daikin_residential, this is a deprecated constant which will be removed in HA Core 2025.1. Use HVACMode.OFF instead, please create a bug report at https://github.com/rospogrigio/daikin_residential/issues
SUPPORT_TARGET_TEMPERATURE was used from daikin_residential, this is a deprecated constant which will be removed in HA Core 2025.1. Use ClimateEntityFeature.TARGET_TEMPERATURE instead, please create a bug report at https://github.com/rospogrigio/daikin_residential/issues
SUPPORT_FAN_MODE was used from daikin_residential, this is a deprecated constant which will be removed in HA Core 2025.1. Use ClimateEntityFeature.FAN_MODE instead, please create a bug report at https://github.com/rospogrigio/daikin_residential/issues
SUPPORT_PRESET_MODE was used from daikin_residential, this is a deprecated constant which will be removed in HA Core 2025.1. Use ClimateEntityFeature.PRESET_MODE instead, please create a bug report at https://github.com/rospogrigio/daikin_residential/issues
SUPPORT_SWING_MODE was used from daikin_residential, this is a deprecated constant which will be removed in HA Core 2025.1. Use ClimateEntityFeature.SWING_MODE instead, please create a bug report at https://github.com/rospogrigio/daikin_residential/issues
STATE_CLASS_MEASUREMENT was used from daikin_residential, this is a deprecated constant which will be removed in HA Core 2025.1. Use SensorStateClass.MEASUREMENT instead, please create a bug report at https://github.com/rospogrigio/daikin_residential/issues
STATE_CLASS_TOTAL_INCREASING was used from daikin_residential, this is a deprecated constant which will be removed in HA Core 2025.1. Use SensorStateClass.TOTAL_INCREASING instead, please create a bug report at https://github.com/rospogrigio/daikin_residential/issues

HA Version: 2024.1
DRC Version: 2.3.1

@jwillemsen
Copy link
Contributor

Fixed as part of https://github.com/jwillemsen/daikin_residential_altherma, that integration also supports the regular Daikin AC models

@MC-Repair-Milano
Copy link
Author

I thank you for the answer.
Happy New Year.
Best regards.

@MC-Repair-Milano
Copy link
Author

I installed the integration but it doesn't see the BRP069C4x and BRP069B4x devices.
I deleted the old integration and installed the new one but the result does not change.
Please, could you help me with the solution?

@jwillemsen
Copy link
Contributor

Please attach your device diagnostics and ha log with debug enabled, see the readme

@MC-Repair-Milano
Copy link
Author

The diagnostics of this integration (https://github.com/jwillemsen/daikin_residential_altherma) or the old one (https://github.com/rospogrigio/daikin_residential)?

@MC-Repair-Milano
Copy link
Author

Sorry but I make few reports and I'm not practical.

@MC-Repair-Milano
Copy link
Author

@jwillemsen
Copy link
Contributor

Ok, looks you installed the wrong one (https://github.com/speleolontra/daikin_residential_altherma), my forked version is not available yet on HACS, you need to pull it manually from git, waiting on hacs/default#2234

@Threesa
Copy link

Threesa commented Jan 4, 2024

Fixed as part of https://github.com/jwillemsen/daikin_residential_altherma, that integration also supports the regular Daikin AC models

Is your fork now the "official" follow-up of rospogrigio's? And this one no longer updated?

@MC-Repair-Milano
Copy link
Author

I manually installed this and it worked.

https://github.com/jwillemsen/daikin_residential_altherma/releases/tag/v3.0.1

I thank you so much.

@jwillemsen
Copy link
Contributor

jwillemsen commented Jan 4, 2024

Fixed as part of https://github.com/jwillemsen/daikin_residential_altherma, that integration also supports the regular Daikin AC models

Is your fork now the "official" follow-up of rospogrigio's? And this one no longer updated?

I have maintained the rospogrigio version for some time but didn't like the way it worked. I worked several weeks on my fork to get a different approach working and did ask @rospogrigio whether I could merge this, it would remove most of his code. Because I didn't got any response I decided to make releases on my fork and try to add it to HACS (see hacs/default#2234), that makes it much easier for me to ship updates and don't break the approach from rospogrigio, all entity ids have changed, breaking existing dashboards/automations

@Threesa
Copy link

Threesa commented Jan 5, 2024

Fixed as part of https://github.com/jwillemsen/daikin_residential_altherma, that integration also supports the regular Daikin AC models

Is your fork now the "official" follow-up of rospogrigio's? And this one no longer updated?

I have maintained the rospogrigio version for some time but didn't like the way it worked. I worked several weeks on my fork to get a different approach working and did ask @rospogrigio whether I could merge this, it would remove most of his code. Because I didn't got any response I decided to make releases on my fork and try to add it to HACS (see hacs/default#2234), that makes it much easier for me to ship updates and don't break the approach from rospogrigio, all entity ids have changed, breaking existing dashboards/automations

Thanks for clarifying and the nice job!!

@rospogrigio
Copy link
Owner

Fixed as part of https://github.com/jwillemsen/daikin_residential_altherma, that integration also supports the regular Daikin AC models

Is your fork now the "official" follow-up of rospogrigio's? And this one no longer updated?

I have maintained the rospogrigio version for some time but didn't like the way it worked. I worked several weeks on my fork to get a different approach working and did ask @rospogrigio whether I could merge this, it would remove most of his code. Because I didn't got any response I decided to make releases on my fork and try to add it to HACS (see hacs/default#2234), that makes it much easier for me to ship updates and don't break the approach from rospogrigio, all entity ids have changed, breaking existing dashboards/automations

Hi @jwillemsen sorry for the long silence but I've been through a really tough personal period which I hope is almost over. I haven't had the time yet to have a look at what you mean by "different approach" but will soon, would you mind if I merge here your new code, or maybe partially? Let me know in case, thank you

@Threesa
Copy link

Threesa commented Jan 5, 2024

Hi @jwillemsen sorry for the long silence but I've been through a really tough personal period which I hope is almost over. I haven't had the time yet to have a look at what you mean by "different approach" but will soon, would you mind if I merge here your new code, or maybe partially? Let me know in case, thank you

Too bad to hear!! I hope you see some light at the end of the bad luck tunnel!

@jwillemsen
Copy link
Contributor

jwillemsen commented Jan 5, 2024

Bad to hear that @rospogrigio, hopefully it is almost over.

I have to correct my comment about what I have done. I am co-maintainer of https://github.com/speleolontra/daikin_residential_altherma, but I am not a maintainer of the version of rospogrigio. I had an idea how to refactor the daikin_residential_altherma version and didn't got a response on that from speleolontra. One of the reasons of the refactoring is that I had the idea that I could also support regular Daikin AC units for which rospogrigio started originally. After weeks of work I was able to finish my refactoring and support all Daikin Onecta App devices, AC an Altherma units. I think I fixed all issues reported in this repo. Some code cleanup can still be done, but it is all functional now.

@rospogrigio When you have time, try to install my version and see how it works, I think it supports all you have done., thanks for all your hard work and hopefully your tough personal period is over soon.

@giof94is
Copy link

giof94is commented Jan 7, 2024

@rospogrigio sorry to hear that, good luck with everything!

Any forecast about when you'll be able to fix the issue here reported?

Thanks!

@rospogrigio
Copy link
Owner

I'm looking into this... one question: why is it deemed so urgent? The constants will be introduced in 2025.1, so in one year...

@jwillemsen OK I'll try your fork as soon as I have some spare time. You didn't answer my question: would you mind if I merge your work into this repo?

@jwillemsen
Copy link
Contributor

2024.1.0 had a bug that the old constants didn't work anymore for some entities, only the new ones worked. They fixed that in 2024.1.1.

@rospogrigio Not a problem to merge my PRs and look at the work done in my fork and merge some of that to your version.

@rospogrigio
Copy link
Owner

2024.1.0 had a bug that the old constants didn't work anymore for some entities, only the new ones worked. They fixed that in 2024.1.1.

I see, this is why I never upgrade to 202*.*.0 versions as soon as they are pushed out but I always wait for the .1 or .2 releases, since if serious bugs come out at the release they are fixed quite urgently 😉 so I'd say there is no real urgency for this fix.

@Ringo982
Copy link

Ringo982 commented Jan 10, 2024

Ok, looks you installed the wrong one (https://github.com/speleolontra/daikin_residential_altherma), my forked version is not available yet on HACS, you need to pull it manually from git, waiting on hacs/default#2234

Hello @jwillemsen , how long it will take to be available on HACS?

@jwillemsen
Copy link
Contributor

Hello @jwillemsen , how long it will take to be available on HACS?

No idea, but it took also a long time to have this integration itself to be added to HACS

@Ivano62
Copy link

Ivano62 commented Jan 11, 2024

The issue persist with latest upgrade on HA 2024.1.2 core.
Thanks

@brinkgit
Copy link

Fixed as part of https://github.com/jwillemsen/daikin_residential_altherma, that integration also supports the regular Daikin AC models

Does this also work for the onecta daikin?

@jwillemsen
Copy link
Contributor

Yes, that should work, my fork supports daikin ac and altherma

@brinkgit
Copy link

OK, thanks, I'll give it a try one of these day's

@brinkgit
Copy link

brinkgit commented Feb 1, 2024

Hello,

I removed the old integration an installed the new one. Restarten HA and there were now less warnings, but still some:

STATE_CLASS_MEASUREMENT was used from daikin_residential, this is a deprecated constant which will be removed in HA Core 2025.1. Use SensorStateClass.MEASUREMENT instead, please create a bug report at https://github.com/rospogrigio/daikin_residential/issues
STATE_CLASS_TOTAL_INCREASING was used from daikin_residential, this is a deprecated constant which will be removed in HA Core 2025.1. Use SensorStateClass.TOTAL_INCREASING instead, please create a bug report at https://github.com/rospogrigio/daikin_residential/issues

and

Entity None (<class 'custom_components.daikin_residential.climate.DaikinClimate'>) is using deprecated supported features values which will be removed in HA Core 2025.1. Instead it should use <ClimateEntityFeature.TARGET_TEMPERATURE|FAN_MODE|PRESET_MODE|SWING_MODE: 57>, please create a bug report at https://github.com/rospogrigio/daikin_residential/issues and reference https://developers.home-assistant.io/blog/2023/12/28/support-feature-magic-numbers-deprecation
Entity None (<class 'custom_components.smartthings.climate.SmartThingsAirConditioner'>) is using deprecated supported features values which will be removed in HA Core 2025.1. Instead it should use <ClimateEntityFeature.TARGET_TEMPERATURE|FAN_MODE|PRESET_MODE|SWING_MODE: 57>, please create a bug report at https://github.com/veista/smartthings/issues and reference https://developers.home-assistant.io/blog/2023/12/28/support-feature-magic-numbers-deprecation

@jwillemsen
Copy link
Contributor

The warnings are from daikin_residential, that is this integration, looks you have still something installed from this integration.

@brinkgit
Copy link

brinkgit commented Feb 1, 2024

How do I get that away? I removed the old daikin residential and restarted HA. When I do as in the manual ADD INTEGRATION and then 'Daikin Residential Controller for Altherma'

I get this screen what seems to point to only one integration, what I thought to be the new one (but maybe it is not?

Scherm­afbeelding 2024-02-01 om 13 06 54

@jwillemsen
Copy link
Contributor

That is another integration, my fork is not yet available on HACS, you have to add it as custom repo with the link to github, see https://hacs.xyz/docs/faq/custom_repositories/

@brinkgit
Copy link

brinkgit commented Feb 1, 2024

Hello,

Sorry for having still issues, but is does noet work as I hoped it would.
u
Uninstalled the old integration, restarted HA, installend Daikin Residential for Altherma 3 via HACS, restarted HA, installed Daikin Residential for Altherma 3 via add integration and that seems to work. The system asked for email and password and tells something is installed,
It shows up in list of integrations:

Scherm­afbeelding 2024-02-01 om 14 53 17

It tells there is 1 item.
But when click on this integration, it looks like this:

Scherm­afbeelding 2024-02-01 om 14 53 04

When I try to add a new device, I get the message:

Scherm­afbeelding 2024-02-01 om 16 13 50

So the device is connected already. But it is nowhere to find any device in HA.
What do I do wrong? Or does mij HAVC (with LAN-adapter BRP069B4X) not work in this integration?

@jwillemsen
Copy link
Contributor

You need to install https://github.com/jwillemsen/daikin_residential_altherma, as integration description it should show "Daikin Residential Controller including Altherma", important is "including.

@brinkgit
Copy link

brinkgit commented Feb 1, 2024

That's it!!
Thanks for your help, warnings are now not coming up and airco can now be controlled again by HA.

@Ivano62
Copy link

Ivano62 commented Feb 7, 2024

The issue persist with latest upgrade on HA 2024.2.0 core.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants