Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reputation - main config, docs and local; redis/sentinel not taken from global #742

Open
styx-tdo opened this issue Apr 27, 2024 · 0 comments

Comments

@styx-tdo
Copy link

styx-tdo commented Apr 27, 2024

In the modules.d/reputation.conf:, it gives:

reputation {
#  rules { 
#    SPF_REPUTATION =  {
#      selector {
#        type = "spf";
#      }
#      backend {
#        type = "redis";
#      }
#      symbol = "SPF_REPUTATION";
#    }
#  }
  .include(try=true,priority=5) "${DBDIR}/dynamic/reputation.conf"
  .include(try=true,priority=1,duplicate=merge) "$LOCAL_CONFDIR/local.d/reputation.conf"
  .include(try=true,priority=10) "$LOCAL_CONFDIR/override.d/reputation.conf"
}   

The commented syntax should be what one can put in local config, however, the local syntax is:
https://rspamd.com/doc/modules/reputation.html

rules {
  ip_reputation = {
    selector "ip" {
    }
    backend "redis" {
      servers = "localhost";
    }
    symbol = "IP_REPUTATION";
  }

This is: a) confusing and b) does not allow to set the backend to redis and use the redis.conf settings (leaving servers empty fails configtest, putting sentinels in there also fails.

Please fix the reputation module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant