From db6439d404506c796490f4c3853c514b4f9445a5 Mon Sep 17 00:00:00 2001 From: Carlos Scheidegger Date: Sat, 24 Aug 2024 08:47:16 -0700 Subject: [PATCH 1/3] add semicolons to appease a brittle parser --- inst/components/scss/sidebar.scss | 2 +- inst/components/scss/value_box.scss | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/inst/components/scss/sidebar.scss b/inst/components/scss/sidebar.scss index 03ddad884..b00198797 100644 --- a/inst/components/scss/sidebar.scss +++ b/inst/components/scss/sidebar.scss @@ -308,7 +308,7 @@ $bslib-sidebar-column-sidebar: Min(calc(100% - var(--_padding-icon)), var(--_sid .bslib-sidebar-layout { &, &.sidebar-right { // Remove sidebar borders in mobile view (except always-open, added below) - > .sidebar { border: none } + > .sidebar { border: none; } // Main area takes up entire layout area to avoid layout shift when // sidebar is expanded as an overlay. diff --git a/inst/components/scss/value_box.scss b/inst/components/scss/value_box.scss index 4650389be..ae6331237 100644 --- a/inst/components/scss/value_box.scss +++ b/inst/components/scss/value_box.scss @@ -85,7 +85,7 @@ $bslib-value-box-horizontal-break-point: 300px !default; @include bootstrap-heading-font-and-spacing($h6-font-size); // add a non-breaking space to ensure it's not 0 height &:empty::after { - content: '\00a0 ' + content: '\00a0 '; } } @@ -93,7 +93,7 @@ $bslib-value-box-horizontal-break-point: 300px !default; @include bootstrap-heading-font-and-spacing($h2-font-size); // add a non-breaking space to ensure it's not 0 height &:empty::after { - content: '\00a0 ' + content: '\00a0 '; } } From 867c3e8f8963503ec9b68cf706b981d53264320a Mon Sep 17 00:00:00 2001 From: Carlos Scheidegger Date: Sat, 24 Aug 2024 08:54:43 -0700 Subject: [PATCH 2/3] NEWS.md entry --- NEWS.md | 1 + 1 file changed, 1 insertion(+) diff --git a/NEWS.md b/NEWS.md index 4db61489c..e37b99231 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,6 +1,7 @@ # bslib (development version) * `navset_card_pills()`, `navset_card_underline()`, `navset_card_tabs()` fixed to now respect header/footer arguments (@tanho63, #1024) +* added terminating semicolons to declarations in `value_box.scss` and `sidebar.scss` to prevent issues with parsers that require them. (@cscheid, #1104) # bslib 0.8.0 From 5a370e27625603975f9353089d61271faa5c8b2a Mon Sep 17 00:00:00 2001 From: Carson Sievert Date: Mon, 26 Aug 2024 11:13:42 -0500 Subject: [PATCH 3/3] Update NEWS.md Co-authored-by: Garrick Aden-Buie --- NEWS.md | 1 - 1 file changed, 1 deletion(-) diff --git a/NEWS.md b/NEWS.md index e37b99231..4db61489c 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,7 +1,6 @@ # bslib (development version) * `navset_card_pills()`, `navset_card_underline()`, `navset_card_tabs()` fixed to now respect header/footer arguments (@tanho63, #1024) -* added terminating semicolons to declarations in `value_box.scss` and `sidebar.scss` to prevent issues with parsers that require them. (@cscheid, #1104) # bslib 0.8.0