Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

board_deparse() for Connect should include server #726

Open
hadley opened this issue Mar 2, 2023 · 2 comments
Open

board_deparse() for Connect should include server #726

hadley opened this issue Mar 2, 2023 · 2 comments
Labels
feature a feature request or enhancement

Comments

@hadley
Copy link
Member

hadley commented Mar 2, 2023

And allow auth to be auto:

board_deparse.pins_board_connect <- function(board, ...) {
  expr(board_connect(server = !!board$server))
}

I think we should leave auth as the default so it'll use whatever is setup in the current environment. But it's possible that you'll have multiple servers set up, so we should specify which one to use.

To make this work fully will require standardising server so it can always take a full url regardless of what auth mechanism is used (i.e. should strip protocol and path when auth = "rsconnect".

@juliasilge juliasilge added the feature a feature request or enhancement label Mar 6, 2023
@juliasilge
Copy link
Member

I think we should leave auth as the default so it'll use whatever is setup in the current environment.

The argument against this would be that some of the options available in auth only work locally and not when deployed to the Connect server, if I understand correctly, and that is the main use case I know about for board_deparse() (take a board object and generate code to create it elsewhere). For example, I believe that auth = "rsconnect" cannot be passed from your local setup to Connect (unless that has changed recently?). The Connect docs here show using auth = "envvar" because folks can set that up locally and it will also work it the same content is run from Connect.

Have there been changes recently to this?

@hadley
Copy link
Member Author

hadley commented May 9, 2023

I think I was trying to say that we shouldn't set the auth argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants