Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package updates shouldn't cause test failures unless behavior changes #249

Open
gadenbuie opened this issue Nov 28, 2023 · 0 comments
Open

Comments

@gadenbuie
Copy link
Member

There are more than a few places where we have embedded package versions into our tests, which means that package updates for key packages can cause our tests to fail. Two recent examples:

There may be a path forward in adding a compare= function as an argument to app$expect_values(), similar to the compare argument of app$expect_screenshot() (added in rstudio/shinytest2#231). We could have a function, e.g. shinycoreci::compare_json_ignore_pkg_versions() that would strip package versions before comparing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant