Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error trying to access Tour in live demo #227

Closed
jcheng5 opened this issue Oct 21, 2023 · 2 comments · Fixed by #239
Closed

Error trying to access Tour in live demo #227

jcheng5 opened this issue Oct 21, 2023 · 2 comments · Fixed by #239
Labels
bug Something isn't working quick

Comments

@jcheng5
Copy link
Member

jcheng5 commented Oct 21, 2023

https://rstudio.github.io/shinyuieditor/live-demo/

Select a template, then click the Tour App button.

image
@nstrayer nstrayer added the bug Something isn't working label Oct 25, 2023
@nstrayer
Copy link
Collaborator

Much like #226 this points to needing e2e tests of the tour mode. This one is due to the tour library using global which, when the editor is embedded as a component into an islands architecture app, doesn't exist like it expects. Should be a fairly easy fix in the build config for the website.

@nstrayer nstrayer added the quick label Oct 25, 2023
@nstrayer
Copy link
Collaborator

Oof, turns out I had already dealt with this. The tour mode uses react-floater which hasn't been updated in a while and relies on webpack conventions of putting in a global variable that would typically just be window. The bandaid is to just assign global to window somewhere before the tour code gets run. I already did this in the main versions of the app in the html template but neglected to do it in the website version. Is fixed in #239.

@nstrayer nstrayer linked a pull request Oct 26, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working quick
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants