Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The v8-stable-el7.spec file contains an chmod +x /usr/bin/* directive in build #71

Open
itkovian opened this issue Mar 23, 2020 · 2 comments

Comments

@itkovian
Copy link

Line 389

%build
chmod +x /usr/bin/*

Any reason for this? Seems like this is not really something we would want to do; it also breaks building the RPM as a non-root user.

@mkrsfcmp
Copy link

Bump. It doesn't really seem necessary (or is necessary in only some very strange case) but indeed does break building with mock.

@alorbach
Copy link
Member

This command is applied inside the mock environment, it was added a few years ago in commit c17d75a as workaround with problems building packages inside a docker container. I didn't spend more time investigating why there was a permission problem inside mock environment which is dynamically created each time.

Perhaps you should use our Fedora 30 based docker container for building? It has all requirements installed needed for building, and it does not need root to run the docker image. See the run.sh shript in our docker repository:
https://github.com/rsyslog/rsyslog-docker/blob/master/dev_env/fedora/pkg_base/30/run.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants