Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: UI - Add Login/Signup modal #30

Open
rt4914 opened this issue Aug 22, 2024 · 7 comments · May be fixed by #55
Open

[Feature Request]: UI - Add Login/Signup modal #30

rt4914 opened this issue Aug 22, 2024 · 7 comments · May be fixed by #55
Assignees
Labels
feature Building something new

Comments

@rt4914
Copy link
Owner

rt4914 commented Aug 22, 2024

Is your feature request related to a problem? Please describe.

Create login signup modal/page for website

Describe the solution you'd like

https://homy-next.vercel.app/
Click on login button in this webiste.

Similar to that we need a modal.
The signup modal should not have Name input
The login modal should not have social buttons

Describe alternatives you've considered

No response

Additional context

No response

@rt4914 rt4914 added the feature Building something new label Aug 22, 2024
@rray524 rray524 self-assigned this Aug 23, 2024
@vanamraghu
Copy link
Collaborator

I will work on this

@vanamraghu vanamraghu self-assigned this Sep 18, 2024
@rray524
Copy link
Collaborator

rray524 commented Sep 18, 2024

@vanamraghu can I work on this? I need some practice due to some gap on last month. No problem if you takeover and continue.

@vanamraghu
Copy link
Collaborator

@rray524 you can work on this thanks

@vanamraghu vanamraghu assigned rray524 and unassigned vanamraghu Sep 18, 2024
@rray524 rray524 assigned KvngJamesNG and unassigned rray524 Sep 19, 2024
@rray524
Copy link
Collaborator

rray524 commented Sep 19, 2024

@KvngJamesNG as per your request, I have assigned it to you.

@KvngJamesNG
Copy link
Collaborator

gladly received @rray524 ... Thanks

@rt4914
Copy link
Owner Author

rt4914 commented Oct 1, 2024

@KvngJamesNG Unassigned you this PR as it is not blocking other work.

@rray524 @vanamraghu @aniketpatidar
This is up for grabs.

@vanamraghu vanamraghu self-assigned this Oct 2, 2024
@vanamraghu
Copy link
Collaborator

Please let me know if any body wants to work on this

vanamraghu added a commit that referenced this issue Oct 3, 2024
1. KlinicAuthform that handles both login & signUp modal
2. KlinicAuthContainer that has tabs to switch b/w login and signup and render the login/signup form
3. Added clsx in package json and installed to handle multiple classes
@vanamraghu vanamraghu linked a pull request Oct 3, 2024 that will close this issue
1 task
@vanamraghu vanamraghu linked a pull request Oct 3, 2024 that will close this issue
1 task
vanamraghu added a commit that referenced this issue Oct 16, 2024
1. KlinicAuthForm renamed to AuthForm that displays the form for login and sign up
2. Modal component created to display the login and sign up form and also state is handled to display modal when close button is clicked or anywhere in the page
3. KlinicAuthContainer is removed and renamed to Modal component
4. Button component modified so that first logo can be displayed following the button text (earlier it was text followed by children) now children is displayed followed by button text
5. Header component is created to display the LogIn button so that when clicked modal and related forms is displayed
vanamraghu added a commit that referenced this issue Oct 16, 2024
1. Removed clsx and making use of classNames to handle display of conditionals for tailwind
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Building something new
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants