-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thumbnail is not changing from the WordPress media #253
Comments
This is a design flaw, if we change and uploaded the selected thumbnail then it removed and replaces the Featured image, As you see buttons are radio buttons, no option for deselecting if the user chooses a custom Featured image then our selection overwrites the user's custom selection. if we make radio buttons into checkboxes then the rtMedia thumbnail will not generate. |
if we change, the End user will lose his option to change the thumbnail image. |
Thumbnail is not changing from the WordPress media # issue 253
Hello @gagan0123, The postmeta table stores the relative path of our images which should probably stored the IDs. The approach which we can use is,
This way we won't be needing any additional Please let me know if this approach seems feasible. Also, I tried adding the cc: @aviral-mittal |
I don't think we should create a taxonomy for thumbnails because the relationship between thumbnails and video is one-to-one relation and ideally taxonomy is used when there is a one-to-many relation If I am not wrong, thumbnails are not attachments here so we can not use them with id. Can you add a featured image (An attachment in WordPress and not a thumbnail ) to the video and check if it appears as a video thumb in the frontend? |
Hello @dishitpala, I totally agree with you & have already tried adding a featured image. After adding the featured image to video everything goes fine but here is the catch:
So, here taxonomy that we will be adding will have no relationship with our video's attachments. It will be used just to hide our thumbnails in gallery. |
@Pathan-Amaankhan Earlier this functionality was working or from the beginning, it not working? |
Yes, I tried this one on a dummy site & it is not working. The above S.S. is from https://easydash.rtcamp.com/sites/details?siteName=amaan-transcoder.rt.gw. Please have a look once. |
@Souptik2001 Can you please look into this |
@pavanpatil1 Did this issue get resolved once the server issue of transcoding was resolved? |
@aviral-mittal, No this issue is still reproducible. |
While changing the thumbnail from the media, it shows the thumbnail saved but while viewing the media the default thumbnail is visible.
Steps to reproduce:
Actual Result: After selecting the thumbnail is not changed.
Expected Result: The user should be able to select and change the thumbnail while editing the media and the thumbnail should be changed as per the selected thumbnail image.
thumnbail.issue.mp4
UPDATE:
Current Behavior
Transcoder with WordPress Media Uploads
Video thumbnail is set based on the featured image uploaded and doesn't depend on the thumbnails generated from transcoding
Ideally, if we are showing the thumbnails after transcoding then those should be shown as featured image
Transcoder with rtMedia Uploads
By default after transcoding featured image is set for the video(which is thumbnail)
Now if we change the thumbnail then the thumbnail is getting updated as expected even if featured image is removed
For rtMedia uploads if featured image is uploaded that doesn't get set as thumbnail as the thumbnails are set from frontend..
Expected Behavior
Transcoder with WordPress Media Uploads
Irrespective of the featured image, the thumbnail should get updated
The text was updated successfully, but these errors were encountered: