Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create production branch #14

Open
twiecki opened this issue Jul 3, 2020 · 2 comments
Open

Create production branch #14

twiecki opened this issue Jul 3, 2020 · 2 comments

Comments

@twiecki
Copy link
Contributor

twiecki commented Jul 3, 2020

We should have a separate "prod" branch from which the model runs so that master can be a bit more stable.

Alternatively, we could have releases and production only ever uses the most recent version which is known to be stable.

@k-sys
Copy link

k-sys commented Jul 6, 2020

I've been going back and forth on this in my mind – any maybe there's no "right" answer, but @mikeyk might have a feeling...

My principles here would be:

  • Allow for fast "bleeding edge" development without worrying about introducing issues into production
  • If someone clones the repo and they're on master, we should generally assume they want to see the same results that are in production. I'm wary of using master as the development branch because it's far less likely to be thoroughly tested/vetted and if someone wants to see our best/stable I think that should be on master rather than telling people "oh hey, checkout this stable branch that's hard to find"

So my proposal is that we use master as our production branch – it's the latest stable branch and doesn't change wildly day to day. For development, we have a development branch on the side that contributors can merge into more freely.

Note this is different than, say, pymc3 where the git repo's default is latest (unstable). Since people are not installing this via pip or conda it becomes more difficult to pin a version so master should be the version we want people using locally, and thus it should be more stable.

@mikeyk
Copy link
Contributor

mikeyk commented Jul 6, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants