Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify the Account #25

Open
vinceyap88 opened this issue Jun 27, 2016 · 3 comments
Open

Specify the Account #25

vinceyap88 opened this issue Jun 27, 2016 · 3 comments
Labels
enhancement

Comments

@vinceyap88
Copy link

Hi,
Is there a way to specify the account number before starting the trading via the API?
:)Vincent Yap
@rterp rterp added the question label Jul 5, 2016
@rterp
Copy link
Owner

rterp commented Jul 5, 2016

hmmm, I don't think that is there yet. What are you intending to use it for? Do you have a master account with multiple sub accounts?

@vinceyap88
Copy link
Author

vinceyap88 commented Jul 5, 2016 •
edited
Loading

I intend to create a family account. I have added the account handling in InteractiveBroker.java and TraderOrder.java. You can review the diff and merge it if it is correct.
InteractiveBrokersBroker.java.diff.txt
TraderOrder.java.diff.txt

@rterp rterp added enhancement and removed question labels Jul 8, 2016
@rterp
Copy link
Owner

rterp commented Jul 8, 2016

Changes look good @vinceyap88 If you want you can create a pull request to submit your changes to be merged into the mainline. Also, if there are any unit tests touching the InteractiveBrokersBroker and the TradeOrder classes, it would be good to test the new account number functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rterp @vinceyap88