Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Preset Saving, T-Junction Errors, and Multi-Map Compilation #245

Open
SnabbSpelare opened this issue Aug 24, 2024 · 5 comments
Open
Labels

Comments

@SnabbSpelare
Copy link

Is your feature request related to a problem? Please describe.
Changes I make to presets in CompilePal don't save after I close the program. Also, I'm getting a 'Too many t-junctions' error that crashes the compile, and I can't easily apply settings to all maps in my list.

Describe the solution you'd like
Please make presets save automatically or give a save option. Also, improve handling of t-junction errors, maybe by giving tips or letting the compile continue. I'd also like a way to apply presets to all maps at once

Describe alternatives you've considered
I've tried fixing these issues manually, but it's slow and frustrating.

Additional context
I've attached a screenshot

@Exactol
Copy link
Collaborator

Exactol commented Aug 25, 2024

Compile Pal is just a wrapper around the existing source engine compiling tools, the "Too many t-juncts" error is coming from the compiler and is something you need to fix. Presets not saving sounds like a bug, what version of Compile Pal are you using? Also the screenshot you attached didnt upload

@Exactol Exactol added bug and removed enhancement labels Aug 25, 2024
@SnabbSpelare
Copy link
Author

I understand that Compile Pal acts as a wrapper for compiling tools like vvis, similar to how batch scripting works, but with a GUI instead (as I see it). I think it's really neat that you've added the parameters to a list, but unfortunately, there doesn't seem to be any checks to verify if the executables support the specified parameters. Is there a reason for this? For example, the program or a batch script could run each tool with '--help' or '/?' to list all the parameters that version supports. For instance, the 64-bit version of Garry's Mod doesn't have the '-nojunc' parameter, but the 32-bit version does. However, if I use that, I think it won't remember the filenames.

Sorry, it seems I forgot to attach the screenshot by mistake. I'm using Compile Pal version 28.x4X. What should I screenshot? This was a few days ago, so I've forgotten the context.

Also, a small suggestion: it would be helpful to have the option to remove all maps in the list. For example, a button named 'Remove All' under 'Remove'.
image

@statecouncil
Copy link

statecouncil commented Aug 28, 2024

Presets not saving sounds like a bug, what version of Compile Pal are you using?

Hi, I've encountered this bug as well, and I know what causes it (me, I caused it, whoops).
I'm distributing a Preset with my BAMF project and I accidentally renamed the Preset's folder (in CompilePal/Presets), but not the preset name in meta.json. If those names are not identical, apparently CompilePal does read the preset just fine but fails to write.

EDIT: As far as I'm aware, this still happens on the latest pre-release.

@SnabbSpelare
Copy link
Author

Presets not saving sounds like a bug, what version of Compile Pal are you using?

Hi, I've encountered this bug as well, and I know what causes it (me, I caused it, whoops). I'm distributing a Preset with my BAMF project and I accidentally renamed the Preset's folder (in CompilePal/Presets), but not the preset name in meta.json. If those names are not identical, apparently CompilePal does read the preset just fine but fails to write.

EDIT: As far as I'm aware, this still happens on the latest pre-release.

I see, thanks for sharing! I did clone one of the default presets. Is that what you did aswell?

@SnabbSpelare
Copy link
Author

New Suggestions:

  1. Skip maps causing errors. currently if you try to compile maps and just one has a error like t-junction it will completely stop processing others. this is dumb. please change this
  2. Being able to clone in Game Selector would be nice. Because for me, I need two for Garry's Mod one for GM 32 and GM 64.
    image
  3. Apply preset to all unselected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants