Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PreviewRename prompt #55

Open
retailcoder opened this issue Mar 12, 2023 · 1 comment
Open

PreviewRename prompt #55

retailcoder opened this issue Mar 12, 2023 · 1 comment
Labels
component: Rubbeduck.UI Issue involves UI components component: Rubberduck.Core Issue involves the Core library feature: code actions Issues relating to code actions ("ducky menu") feature: editor shell Issues that relate to the editor shell skill:xaml Issues that involve XAML markup and WPF

Comments

@retailcoder
Copy link
Member

Before a rename operation is executed, its impacts are assessed, and the user gets an opportunity to [p]review and skip individual diffs if needed:

rename preview confirmation prompt

The number of locations and modules affected could theoretically reflect the checked items - the OK button should be disabled if none are selected (operation would be no-op).

This is purely client-side functionality: the preview diff literally consists of document edits to be performed.

@retailcoder retailcoder added component: Rubberduck.Core Issue involves the Core library component: Rubbeduck.UI Issue involves UI components skill:xaml Issues that involve XAML markup and WPF feature: editor shell Issues that relate to the editor shell feature: code actions Issues relating to code actions ("ducky menu") labels Mar 12, 2023
@Vogel612
Copy link
Member

I like the mockup, but I would want to expose more context lines for the diff, possibly user-configurable, but default more than 2 and less than 5, just to ensure that the user can actually understand what the heck is happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Rubbeduck.UI Issue involves UI components component: Rubberduck.Core Issue involves the Core library feature: code actions Issues relating to code actions ("ducky menu") feature: editor shell Issues that relate to the editor shell skill:xaml Issues that involve XAML markup and WPF
Projects
None yet
Development

No branches or pull requests

2 participants