Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests and find other incorrect uses of :user instead of resource_name #40

Open
tcannonfodder opened this issue Jul 3, 2023 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@tcannonfodder
Copy link
Contributor

In 5ef8c83, we found code that used :user instead of resource_name. This would cause issues when implementing passkey controllers for non-user resources.

We need to:

  • Check the rest of the codebase for any additional uses of :user that should be resource_name
  • Write tests to prevent regressions, since there do not appear to be any
@tcannonfodder tcannonfodder added good first issue Good for newcomers help wanted Extra attention is needed labels Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant