Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX PROJECT + DEFAULT OPEN on Accordion #122

Closed
wants to merge 7 commits into from
Closed

FIX PROJECT + DEFAULT OPEN on Accordion #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
eb1e222
1st OK
pierry01 Oct 23, 2024
434b783
OOPS
pierry01 Oct 23, 2024
9069819
1st OK
pierry01 Oct 23, 2024
2aa664a
FIX PROJECT
pierry01 Oct 23, 2024
e83382f
FIX ACCORDION VIEW
pierry01 Oct 23, 2024
516974b
OOPS
pierry01 Oct 23, 2024
892fbd9
Revert "OOPS"
pierry01 Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ end

gem "phlex-rails"

gem "rbui", github: "rbui-labs/rbui", branch: "main"
# gem "rbui", path: "../rbui"
gem "ruby_ui", github: "rbui-labs/ruby_ui", branch: "main"
# gem "ruby_ui", path: "../ruby_ui"
Comment on lines +78 to +79
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is still a lot of typo that rbui should be ruby_ui, but it deserves another PR


gem "pry"
10 changes: 5 additions & 5 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
GIT
remote: https://github.com/rbui-labs/rbui.git
revision: 9428238764f51f5039dffcfa76ba4e90ab77f74b
remote: https://github.com/rbui-labs/ruby_ui.git
revision: aef90c62469a5221affe4493c76f2f3d3589f9b6
branch: main
specs:
rbui (1.0.0.pre.alpha.3)
ruby_ui (1.0.0.pre.alpha.4)
phlex (~> 1.10)
rouge (~> 4.2.0)
tailwind_merge (>= 0.12)
Expand Down Expand Up @@ -300,7 +300,7 @@ GEM
railties (>= 6.0.0)
stringio (3.1.1)
strscan (3.1.0)
tailwind_merge (0.13.0)
tailwind_merge (0.13.2)
lru_redux (~> 1.1)
thor (1.3.1)
timeout (0.4.1)
Expand Down Expand Up @@ -353,7 +353,7 @@ DEPENDENCIES
pry
puma (= 6.4.2)
rails (= 7.2.0)
rbui!
ruby_ui!
selenium-webdriver
sqlite3 (>= 1.4)
standard
Expand Down
2 changes: 1 addition & 1 deletion app/views/application_view.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class ApplicationView < ApplicationComponent
# can change that to `Phlex::HTML` if you want to keep views and
# components independent.

GITHUB_REPO_URL = "https://github.com/rbui-labs/rbui/"
GITHUB_REPO_URL = "https://github.com/rbui-labs/ruby_ui/"
GITHUB_FILE_URL = "#{GITHUB_REPO_URL}blob/main/"

def before_template
Expand Down
2 changes: 1 addition & 1 deletion app/views/docs/accordion_view.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ def view_template
@@code = <<~RUBY
div(class: "w-full") do
Accordion do
AccordionItem do
AccordionItem(open: true) do
AccordionTrigger do
p(class: "font-medium") { "What is PhlexUI?" }
AccordionIcon()
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"esbuild": "0.23.0",
"lottie-web": "5.12.2",
"postcss": "8.4.40",
"rbui-js": "rbui-labs/rbui",
"rbui-js": "rbui-labs/ruby_ui",
"tailwindcss": "3.4.7",
"tailwindcss-animate": "1.0.7"
},
Expand Down
18 changes: 3 additions & 15 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -819,21 +819,9 @@ queue-microtask@^1.2.2:
resolved "https://registry.npmjs.org/queue-microtask/-/queue-microtask-1.2.3.tgz"
integrity sha512-NuaNSa6flKT5JaSYQzJok04JzTL1CA6aGhv5rfLW3PgqA+M2ChpZQnAC8h8i4ZFkBS8X5RqkDBHA7r4hej3K9A==

rbui-js@../rbui:
version "1.0.0-alpha.3"
dependencies:
"@floating-ui/dom" "^1.6.8"
"@hotwired/stimulus" "^3.2.2"
chart.js "^4.4.1"
date-fns "^2.30.0"
fuse.js "^7.0.0"
motion "^10.16.4"
mustache "^4.2.0"
tippy.js "^6.3.7"

rbui-js@rbui-labs/rbui:
version "1.0.0-alpha.3"
resolved "https://codeload.github.com/rbui-labs/rbui/tar.gz/301f325d1161a59ffdfecb02403754f8dad30c37"
rbui-js@rbui-labs/ruby_ui:
version "1.0.0-alpha.4"
resolved "https://codeload.github.com/rbui-labs/ruby_ui/tar.gz/aef90c62469a5221affe4493c76f2f3d3589f9b6"
dependencies:
"@floating-ui/dom" "^1.6.8"
"@hotwired/stimulus" "^3.2.2"
Expand Down