Admin policy test coverage #5262
Conversation
Remove unused code in Api::ApplicationPolicy
martinemde
force-pushed
the
martinemde/increase-coverage
branch
from
cd621ff
to
f8115a3
Compare
|
@martinemde happy to finish the rest later (in additional PR) |
martinemde
force-pushed
the
martinemde/increase-coverage
branch
from
f8115a3
to
6cd0f31
Compare
|
@simi If it seems useful, we can continue. I noticed that their coverage is "fake" before this (i.e. the method is called so it counts as coverage). I'm aiming for a |
| refute_authorizes(user, record, :"view_#{association}?") | ||
| end | ||
|
|
||
| # TODO: I'm not clear on what `record` is used in show_association? |
There was a problem hiding this comment.
My intention here was to use the passed policy to assert that it refers to that policy, but I'm unclear on how that works.
Is it really getting passed the "object" of the association as the record or are we just looking up the same policy as self because it's not a different record? That would imply that record is not a RubyGem in the RubyGemPolicy when we plan on checking show_association?
I started a pattern here for testing associations but I'm getting really bored of adding it all 🥱 Maybe we can finish it later. It's very repetitive.