Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes salesforce connector errors #142

Merged
merged 4 commits into from
Aug 21, 2023

Conversation

a-rampalli
Copy link

What

  1. Changed date format in latest image blocking source creation.
  2. Some resources sync failing.
    Issues detailed in comments here (https://linear.app/rudderstack/issue/ETL-55/salesforce-image-update)

@a-rampalli a-rampalli requested a review from am6010 August 21, 2023 05:25
@linear
Copy link

linear bot commented Aug 21, 2023

ETL-55 Salesforce image update

Update current salesforce v4.0.5 image to v8.1.0

@github-actions
Copy link

Before Merging a Connector Pull Request

Wow! What a great pull request you have here! 🎉

To merge this PR, ensure the following has been done/considered for each connector added or updated:

  • PR name follows PR naming conventions
  • Breaking changes are considered. If a Breaking Change is being introduced, ensure an Airbyte engineer has created a Breaking Change Plan and you've followed all steps in the Breaking Changes Checklist
  • Connector version has been incremented in the Dockerfile and metadata.yaml according to our Semantic Versioning for Connectors guidelines
  • Secrets in the connector's spec are annotated with airbyte_secret
  • All documentation files are up to date. (README.md, bootstrap.md, docs.md, etc...)
  • Changelog updated in docs/integrations/<source or destination>/<name>.md with an entry for the new version. See changelog example
  • The connector tests are passing in CI
  • You've updated the connector's metadata.yaml file (new!)
  • If set, you've ensured the icon is present in the platform-internal repo. (Docs)

If the checklist is complete, but the CI check is failing,

  1. Check for hidden checklists in your PR description

  2. Toggle the github label checklist-action-run on/off to re-run the checklist CI.

@a-rampalli a-rampalli merged commit c3665e8 into main Aug 21, 2023
4 of 7 checks passed
@@ -37,7 +37,6 @@ connectionSpecification:
pattern: >-
^([0-9]{4}-[0-9]{2}-[0-9]{2}(T[0-9]{2}:[0-9]{2}:[0-9]{2}Z)?)$
examples:
- "2021-07-25"
- "2021-07-25T00:00:00Z"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@a-rampalli will this impact existing connections ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked backward compatibility. No issues with syncs

Copy link
Author

@a-rampalli a-rampalli Aug 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-08-21 at 6 59 56 PM

Will show an error in configuration screen for existing sources but syncs work fine. This can be fixed if user selects start date again (Will be stored in the new format in db now). Didn't add as a step for customer as it is not strictly necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants