Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: clevertap integration #196

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

muhammadfarhanshakil
Copy link

@muhammadfarhanshakil muhammadfarhanshakil commented Nov 13, 2024

Description of the change

I have added support for Clevertap, a popular customer engagement and retention platform. This PR will add a new package rudder_integration_clevertap_flutter: ^1.0.0 on pub.dev.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • [x ] Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@muhammadfarhanshakil muhammadfarhanshakil requested a review from a team as a code owner November 13, 2024 12:58
@muhammadfarhanshakil muhammadfarhanshakil marked this pull request as draft November 13, 2024 13:04
@muhammadfarhanshakil muhammadfarhanshakil marked this pull request as ready for review November 13, 2024 13:05
@1abhishekpandey
Copy link
Contributor

Hey @muhammadfarhanshakil,

Thanks for creating this new integration. I've forwarded this request to our team for further consideration.

@ChryssaAliferi
Copy link
Contributor

@muhammadfarhanshakil Thank you very much for contributing a whole new integration! Give us some time to review this, and we will respond. In the meantime, does your local implementation cover your current needs, until we are ready to merge and release this?

@muhammadfarhanshakil
Copy link
Author

@ChryssaAliferi @1abhishekpandey Thanks for the prompt response and for considering my contribution! I’m glad to know you’ll be reviewing it. My local implementation is meeting my current needs, so there’s no rush on my end. I’m happy to make any adjustments if needed to align with the project’s standards. Please let me know if there’s anything specific you’d like me to address as you go through the review.

Thanks again!

@contributor-support
Copy link

Thank you @muhammadfarhanshakil for contributing this PR.
Please sign the Contributor License Agreement (CLA) before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants