Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: memory issue crash happening on CloudModeProcessor #539

Merged
merged 3 commits into from
Oct 7, 2024
Merged

fix: memory issue crash happening on CloudModeProcessor #539

merged 3 commits into from
Oct 7, 2024

Conversation

SKannaniOS
Copy link
Contributor

@SKannaniOS SKannaniOS commented Oct 1, 2024 •
edited
Loading

Description

  • This PR resolves a significant memory issue that was causing crashes in the CloudModeProcessor class.
  • To fix this, we’ve updated the method for reading events in cloud mode to enhance memory management.
  • Additionally, the implementation now includes catching potential errors and providing users with a debug log for better insight into the issue.

@SKannaniOS SKannaniOS added the v1 label Oct 1, 2024
@SKannaniOS SKannaniOS self-assigned this Oct 1, 2024
@SKannaniOS SKannaniOS marked this pull request as ready for review October 4, 2024 16:03
@SKannaniOS SKannaniOS requested a review from a team as a code owner October 4, 2024 16:03
ChryssaAliferi
ChryssaAliferi previously approved these changes Oct 4, 2024
View reviewed changes
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 7, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
58.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

ChryssaAliferi
ChryssaAliferi approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@ChryssaAliferi ChryssaAliferi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@SKannaniOS SKannaniOS changed the title fix: memory issue crash on v1 sdk fix: memory issue crash happening on CloudModeProessor Oct 7, 2024
@SKannaniOS SKannaniOS changed the title fix: memory issue crash happening on CloudModeProessor fix: memory issue crash happening on CloudModeProcessor Oct 7, 2024
@SKannaniOS SKannaniOS merged commit ddc2d05 into develop Oct 7, 2024
20 checks passed
@SKannaniOS SKannaniOS deleted the fix/sdk-2463-resolve-the-memory-issue-causing-crashes-in-the-v1-sdk branch October 7, 2024 13:32
@saikumarrs saikumarrs linked an issue Oct 8, 2024 that may be closed by this pull request
BUG : Crash RSDBPersistentManager getEventsFromDB:] #538
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1abhishekpandey 1abhishekpandey 1abhishekpandey approved these changes

@ChryssaAliferi ChryssaAliferi ChryssaAliferi approved these changes

Assignees

@SKannaniOS SKannaniOS

Labels
v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG : Crash RSDBPersistentManager getEventsFromDB:]
3 participants
@SKannaniOS @ChryssaAliferi @1abhishekpandey