Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add support for EU region specific script #1305

Merged
merged 4 commits into from
Aug 17, 2023

Conversation

anantjain45823
Copy link
Contributor

PR Description

We are not incorporating src in customerIo according to region instead using non-euone only as constant.
This PR is fixing this issue by incorporating eu region specific src as well

Notion ticket

Ticket link

Screenshots

Please add screenshots for any new features or UI bug fixes for the following browsers -

  • Chrome
  • Firefox
  • Safari

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@anantjain45823 anantjain45823 added the Ready for review Changes are ready to be reviewed label Aug 16, 2023
@anantjain45823 anantjain45823 self-assigned this Aug 16, 2023
@anantjain45823 anantjain45823 changed the title fix: customerio incorporating eu region src during initialisation fix(INT162): customerio incorporating eu region src during initialisation Aug 16, 2023
yashasvibajpai
yashasvibajpai previously approved these changes Aug 16, 2023
@github-actions
Copy link

github-actions bot commented Aug 16, 2023

size-limit report 📦

Name Size (Base) Size (Current) Size Limit Status
Core - CDN 36.56 KB 36.56 KB (0%) 39.94 KB
All Integrations - CDN 426.58 KB 426.61 KB (+0.01% ▲) 433.11 KB
Core - NPM 36.51 KB 36.51 KB (0%) 39.84 KB
Service Worker - NPM 27.8 KB 27.8 KB (0%) 28.03 KB

@anantjain45823 anantjain45823 changed the title fix(INT162): customerio incorporating eu region src during initialisation feat(INT-162) : add support for EU region specific script. Aug 16, 2023
@linear
Copy link

linear bot commented Aug 16, 2023

INT-162 CustomerIO Destination Gaps

There are certain gaps in our customerIo implementation which are listed as below

  1. we are not prioritizing timestamp over original timestamp at all places.

  2. We can take leverage of cio_id(given to user by cutomerIo) for updating the user, grouping the user or mapping/deleting some device and even for alias call which we are not doing currently.

  3. For group call if there are no identifiers present then also we seem to be making the call which is not correct since the data is missing we should through instrumentation error from transformer itself before sending the request to customerIo.

    https://customer.io/docs/api/track/#operation/identify

  4. Prevent bugsnag issue by making use of optional parameters or validation layer

  5. Enable EU vs US region server configuration in UI (cc: yashasvi )

https://www.notion.so/rudderstacks/CustomerIo-Gaps-Research-Spec-f010ca9b44fb483fab57f876213becfe?pvs=4

@anantjain45823 anantjain45823 changed the title feat(INT-162) : add support for EU region specific script. feat: add support for EU region specific script. Aug 16, 2023
@anantjain45823 anantjain45823 changed the title feat: add support for EU region specific script. feat: add support for EU region specific script Aug 16, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@anantjain45823 anantjain45823 changed the title feat: add support for EU region specific script fix: add support for EU region specific script Aug 17, 2023
@anantjain45823 anantjain45823 merged commit 66092d3 into production-staging Aug 17, 2023
9 checks passed
@anantjain45823 anantjain45823 deleted the fix.cio branch August 17, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for review Changes are ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants