chore(release): pulling release/3.7.0 into main #1703
Conversation
* feat: added custom domain support in ga4 * fix: modified browser test case * fix: update packages/analytics-js-integrations/src/integrations/GA4/browser.js Co-authored-by: Gauravudia <[email protected]> * fix: handling trailing slash in base url --------- Co-authored-by: Gauravudia <[email protected]>
* feat: supporting add to cart for criteo * fix: adding test cases
* feat: warn users on missing plugins * feat: structure the log messages * feat: add data plane events state * refactor: merge plugin filtering and configuration checking logic * refactor: clean up * test: add tests for updateDataPlaneEventsStateFromLoadOptions * fix: use types in signal creation Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * fix: add missing import * fix: add tests and refactor code * test: update descriptions as per coderabbitai suggestions --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* feat: add autoConfig support in FBPixel, add tests * chore: add undefined check for autoconfig
devops-github-rudderstack
requested review from
ItsSudip and
shrouti1507
as code owners
devops-github-rudderstack
requested review from
sandeepdsvs and
koladilip
as code owners
WalkthroughThis update encompasses a variety of enhancements across Chrome extensions, various JavaScript frameworks, and analytics integration packages. It includes HTML title revisions, updates to analytics snippet versions and methods, the introduction of optional chaining in JavaScript codebases for increased safety, and specific improvements in analytics integrations like Criteo and GA4. Additionally, adjustments were made to configuration settings in Symfony and Gatsby, and performance tweaks in analytics storage management. Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files ignored due to path filters (49)
Files selected for processing (56)
Files not processed due to max files limit (8)
Files skipped from review due to trivial changes (15)
Additional Context UsedLearnings (1)
Additional comments not posted (83)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1703 +/- ##
==========================================
+ Coverage 53.92% 54.14% +0.21%
==========================================
Files 461 462 +1
Lines 15615 15648 +33
Branches 3098 3113 +15
==========================================
+ Hits 8421 8472 +51
+ Misses 5899 5848 -51
- Partials 1295 1328 +33 ☔ View full report in Codecov by Sentry. |
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 13
Out of diff range and nitpick comments (23)
packages/analytics-js-common/CHANGELOG_LATEST.md (1)
6-6: Consider revising the phrase "supporting add to cart for criteo" to "added support for 'add to cart' in Criteo" for grammatical correctness.examples/symfony/USAGE.md (1)
Line range hint
9-11: Correct the capitalization in the anchor links to ensure they are valid and match the actual section IDs.-#Webpack-Encore -#Twig-template -#External-resources +#webpack-encore +#twig-template +#external-resourcespackages/analytics-js-integrations/src/integrations/TVSquared/browser.js (1)
Line range hint
1-1: Ensure that the ESLint rules are appropriately configured to maintain code quality and avoid disabling them unless absolutely necessary.packages/analytics-js-integrations/src/integrations/Criteo/browser.js (2)
80-80: Consider whether the warning log in thepagemethod is necessary or if it could be handled more gracefully.
103-103: Review the necessity of the warning log when properties are missing in thetrackmethod.packages/analytics-js-common/CHANGELOG.md (2)
10-10: Clarify the description for the feature related to Criteo.Consider changing "supporting add to cart for criteo" to "Added support for 'add to cart' events in Criteo integration."
Line range hint
148-148: Correct heading levels to ensure they increment by one level at a time.- ### Features + ## Featurespackages/analytics-js-plugins/CHANGELOG.md (2)
Line range hint
15-15: Clarify the description of the bug fix for better understanding.Consider rephrasing to explicitly state what the backward compatibility entails.
Line range hint
25-25: Ensure proper markdown list formatting for bug fixes.- * optimize localstorage transactions ([#1651](https://github.com/rudderlabs/rudder-sdk-js/issues/1651)) ([1289217](https://github.com/rudderlabs/rudder-sdk-js/commit/12892176578dd3628fded2311ea2548e3ff5802c)) + - Optimize localstorage transactions ([#1651](https://github.com/rudderlabs/rudder-sdk-js/issues/1651)) ([1289217](https://github.com/rudderlabs/rudder-sdk-js/commit/12892176578dd3628fded2311ea2548e3ff5802c))packages/analytics-js-integrations/CHANGELOG.md (2)
Line range hint
22-22: Consider changing "warn" to "warning" to clarify the log level.- * making the error message as warn ([#1686](https://github.com/rudderlabs/rudder-sdk-js/issues/1686)) ([56e34be](https://github.com/rudderlabs/rudder-sdk-js/commit/56e34be3575f66531bfe4910ff4aa970ed2ee208)) + * making the error message as warning ([#1686](https://github.com/rudderlabs/rudder-sdk-js/issues/1686)) ([56e34be](https://github.com/rudderlabs/rudder-sdk-js/commit/56e34be3575f66531bfe4910ff4aa970ed2ee208))
Line range hint
255-255: Correct the heading level for consistency in document structure.- ### [3.0.0-beta.5](https://github.com/rudderlabs/rudder-sdk-js/compare/@rudderstack/[email protected]...@rudderstack/[email protected]) (2023-08-21) + ## [3.0.0-beta.5](https://github.com/rudderlabs/rudder-sdk-js/compare/@rudderstack/[email protected]...@rudderstack/[email protected]) - 2023-08-21packages/analytics-js/__tests__/components/core/Analytics.test.ts (3)
Line range hint
58-89: Refactor lifecycle state tests for clarity and maintainability.The test case for
startLifecyclemethod is complex and involves many state changes and spy checks. Consider breaking it down into smaller, more focused tests. This will improve both clarity and maintainability. Each state transition could potentially be its own test, which would make it easier to understand what each part of the test is verifying.
Line range hint
230-260: Enhance test coverage for user session changes.The test cases for the
identifymethod focus on whether the user ID is set and if the session needs to be reset. However, they could be enhanced by verifying that all user-related state changes are handled correctly, especially when the user ID changes. This would ensure that the method behaves correctly in all scenarios.
Line range hint
350-400: Clarify and simplify consent handling tests.The test cases for the
consentmethod are quite complex, involving multiple settings and state changes. Consider simplifying these tests or breaking them down into smaller units. This would make it easier to understand and maintain the tests, and ensure that each aspect of consent handling is thoroughly tested.packages/analytics-js/CHANGELOG.md (9)
14-14: Add a brief description for the patch added tostorejsfor clarity on what the change entails.
Line range hint
223-223: Change the heading level from h3 to h2 to maintain a proper incremental sequence.- ### Dependency Updates + ## Dependency Updates
Line range hint
242-242: Change the heading level from h3 to h2 to maintain a proper incremental sequence.- ### Features + ## Features
Line range hint
253-253: Change the heading level from h3 to h2 to maintain a proper incremental sequence.- ### Bug Fixes + ## Bug Fixes
Line range hint
264-264: Change the heading level from h3 to h2 to maintain a proper incremental sequence.- ### Dependency Updates + ## Dependency Updates
Line range hint
276-276: Change the heading level from h3 to h2 to maintain a proper incremental sequence.- ### Features + ## Features
Line range hint
236-238: Remove the extra blank lines to maintain consistency.- - -
Line range hint
30-30: Add a blank line above the heading for better readability and to adhere to markdown best practices.+
Line range hint
220-220: Ensure there is only one top-level heading in the document to adhere to best practices.- # Change Log + ## Change Log
size-limit report 📦
|
👑 An automated PR
Summary by CodeRabbit
New Features
Bug Fixes
useLegacySDKproperty from Gatsby configuration.Documentation
Refactor
Chores