Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: revert sanitization changes #1916

Merged
merged 2 commits into from
Nov 11, 2024
Merged

fix: revert sanitization changes #1916

merged 2 commits into from
Nov 11, 2024

Conversation

MoumitaM
Copy link
Contributor

@MoumitaM MoumitaM commented Nov 11, 2024 •
edited
Loading

PR Description

Reverted PRs(#1902 and #1907)

Linear task (optional)

Linear task link

Cross Browser Tests

Please confirm you have tested for the following browsers:

  • Chrome
  • Firefox
  • IE11

Sanity Suite

  • All sanity suite test cases pass locally

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@MoumitaM
Revert "feat: add error handling to all public apis (#1907)"
ef1a977 
This reverts commit 9fbaf81.

revert: error handling changes to all public apis
@MoumitaM
Revert "feat: sanitize input data (#1902)"
77259d5 
This reverts commit b71c44a.

revert: sanitization of input data
@MoumitaM MoumitaM requested review from a team as code owners November 11, 2024 13:01
@MoumitaM MoumitaM requested review from yashasvibajpai and shrouti1507 and removed request for a team November 11, 2024 13:01
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 11, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (2)
  • main
  • develop

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov Codecov
Copy link

codecov bot commented Nov 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.83333% with 11 lines in your changes missing coverage. Please review.

Project coverage is 57.49%. Comparing base (0c56231) to head (77259d5).
Report is 1 commits behind head on hotfix/revert-sanitization.

Files with missing lines Patch % Lines
packages/analytics-js/src/app/RudderAnalytics.ts 91.78% 4 Missing and 2 partials ⚠️
packages/analytics-js/src/constants/logMessages.ts 81.81% 2 Missing ⚠️
...s/analytics-js-common/src/constants/logMessages.ts 80.00% 1 Missing ⚠️
...ckages/analytics-js-common/src/utilities/errors.ts 66.66% 1 Missing ⚠️
.../analytics-js-plugins/src/beaconQueue/utilities.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@                      Coverage Diff                       @@
##           hotfix/revert-sanitization    #1916      +/-   ##
==============================================================
- Coverage                       57.69%   57.49%   -0.21%     
==============================================================
  Files                             485      485              
  Lines                           16569    16493      -76     
  Branches                         3320     3311       -9     
==============================================================
- Hits                             9560     9482      -78     
+ Misses                           5762     5732      -30     
- Partials                         1247     1279      +32

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 11, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
93.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

size-limit report 📦

Name Size (Base) Size (Current) Size Limit Status
Plugins Module Federation Mapping - Legacy - CDN 332 B 332 B (0%) 512 B ✅
Plugins - Legacy - CDN 15.49 KB 15.62 KB (+0.86% ▲) 16 KB ✅
Plugins Module Federation Mapping - Modern - CDN 331 B 331 B (0%) 512 B ✅
Plugins - Modern - CDN 7.2 KB 7.2 KB (-0.07% ▼) 7.5 KB ✅
Common - No bundling 16.27 KB 16.27 KB (0%) 16.5 KB ✅
Cookies Utils - Legacy - NPM (ESM) 1.45 KB 1.54 KB (+6.27% ▲) 2 KB ✅
Cookies Utils - Legacy - NPM (CJS) 1.65 KB 1.75 KB (+5.55% ▲) 2 KB ✅
Cookies Utils - Legacy - NPM (UMD) 1.43 KB 1.53 KB (+6.89% ▲) 2 KB ✅
Cookies Utils - Modern - NPM (ESM) 1.11 KB 1.17 KB (+5.56% ▲) 1.5 KB ✅
Cookies Utils - Modern - NPM (CJS) 1.34 KB 1.4 KB (+4.83% ▲) 1.5 KB ✅
Cookies Utils - Modern - NPM (UMD) 1.08 KB 1.16 KB (+6.58% ▲) 1.5 KB ✅
Load Snippet 778 B 778 B (0%) 1 KB ✅
Core (v1.1) - NPM (ESM) 30.3 KB 30.32 KB (+0.06% ▲) 32 KB ✅
Core (v1.1) - NPM (CJS) 30.59 KB 30.52 KB (-0.25% ▼) 32 KB ✅
Core (v1.1) - NPM (UMD) 30.39 KB 30.36 KB (-0.12% ▼) 32 KB ✅
Core (Content Script - v1.1) - NPM (ESM) 29.87 KB 29.88 KB (+0.03% ▲) 30.5 KB ✅
Core (Content Script - v1.1) - NPM (CJS) 30.1 KB 30.08 KB (-0.06% ▼) 30.5 KB ✅
Core (Content Script - v1.1) - NPM (UMD) 29.96 KB 29.92 KB (-0.13% ▼) 30 KB ✅
Core - Legacy - CDN 48.58 KB 48.44 KB (-0.3% ▼) 48.5 KB ✅
Core - Modern - CDN 24.88 KB 24.78 KB (-0.42% ▼) 25 KB ✅
Core - Legacy - NPM (ESM) 48.42 KB 48.3 KB (-0.24% ▼) 48.5 KB ✅
Core - Legacy - NPM (CJS) 48.67 KB 48.52 KB (-0.31% ▼) 49 KB ✅
Core - Legacy - NPM (UMD) 48.44 KB 48.29 KB (-0.31% ▼) 48.5 KB ✅
Core - Modern - NPM (ESM) 24.67 KB 24.53 KB (-0.57% ▼) 25 KB ✅
Core - Modern - NPM (CJS) 24.85 KB 24.72 KB (-0.5% ▼) 25 KB ✅
Core - Modern - NPM (UMD) 24.71 KB 24.53 KB (-0.75% ▼) 25 KB ✅
Core (Bundled) - Legacy - NPM (ESM) 48.42 KB 48.3 KB (-0.24% ▼) 48.5 KB ✅
Core (Bundled) - Legacy - NPM (CJS) 48.68 KB 48.5 KB (-0.37% ▼) 49 KB ✅
Core (Bundled) - Legacy - NPM (UMD) 48.44 KB 48.29 KB (-0.31% ▼) 48.5 KB ✅
Core (Bundled) - Modern - NPM (ESM) 39.5 KB 39.41 KB (-0.25% ▼) 40 KB ✅
Core (Bundled) - Modern - NPM (CJS) 39.69 KB 39.65 KB (-0.11% ▼) 40 KB ✅
Core (Bundled) - Modern - NPM (UMD) 39.45 KB 39.39 KB (-0.14% ▼) 40 KB ✅
Core (Content Script) - Legacy - NPM (ESM) 47.84 KB 47.73 KB (-0.23% ▼) 48 KB ✅
Core (Content Script) - Legacy - NPM (CJS) 48.07 KB 47.98 KB (-0.18% ▼) 48 KB ✅
Core (Content Script) - Legacy - NPM (UMD) 47.82 KB 47.7 KB (-0.26% ▼) 48 KB ✅
Core (Content Script) - Modern - NPM (ESM) 38.96 KB 38.82 KB (-0.38% ▼) 39.5 KB ✅
Core (Content Script) - Modern - NPM (CJS) 39.21 KB 39.11 KB (-0.28% ▼) 40 KB ✅
Core (Content Script) - Modern - NPM (UMD) 38.92 KB 38.89 KB (-0.07% ▼) 39 KB ✅
Service Worker - Legacy - NPM (ESM) 30.59 KB 30.59 KB (0%) 31 KB ✅
Service Worker - Legacy - NPM (CJS) 30.86 KB 30.86 KB (0%) 31 KB ✅
Service Worker - Legacy - NPM (UMD) 30.64 KB 30.64 KB (0%) 31 KB ✅
Service Worker - Modern - NPM (ESM) 25.74 KB 25.74 KB (0%) 26 KB ✅
Service Worker - Modern - NPM (CJS) 26 KB 26 KB (0%) 26.5 KB ✅
Service Worker - Modern - NPM (UMD) 25.77 KB 25.77 KB (0%) 26 KB ✅
All Integrations - Legacy - CDN 94.83 KB 94.83 KB (0%) 95.3 KB ✅
All Integrations - Modern - CDN 89.92 KB 89.92 KB (0%) 91 KB ✅

@MoumitaM MoumitaM merged commit 890fb7b into hotfix/revert-sanitization Nov 11, 2024
11 checks passed
@MoumitaM MoumitaM deleted the fix.revert-sanitization branch November 11, 2024 14:25
@coderabbitai coderabbitai bot mentioned this pull request Nov 18, 2024
Draft
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saikumarrs saikumarrs saikumarrs approved these changes

@yashasvibajpai yashasvibajpai Awaiting requested review from yashasvibajpai yashasvibajpai was automatically assigned from rudderlabs/integrations

@shrouti1507 shrouti1507 Awaiting requested review from shrouti1507 shrouti1507 was automatically assigned from rudderlabs/integrations

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MoumitaM @saikumarrs