Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: garl record event support #3403

Merged
merged 12 commits into from
Jun 18, 2024
Merged

feat: garl record event support #3403

merged 12 commits into from
Jun 18, 2024

Conversation

Vikas26021999
Copy link
Contributor

What are the changes introduced in this PR?

record event changes for GARL

What is the related Linear task?

Resolves REV-1011

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 97.79006% with 4 lines in your changes missing coverage. Please review.

Project coverage is 88.06%. Comparing base (ca5568e) to head (9e8fc47).
Report is 1 commits behind head on develop.

Files Patch % Lines
...oogle_adwords_remarketing_lists/recordTransform.js 96.61% 2 Missing ⚠️
...ions/google_adwords_remarketing_lists/transform.js 91.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3403      +/-   ##
===========================================
+ Coverage    88.03%   88.06%   +0.02%     
===========================================
  Files          574      577       +3     
  Lines        31056    31150      +94     
  Branches      7410     7424      +14     
===========================================
+ Hits         27340    27431      +91     
+ Misses        3405     3380      -25     
- Partials       311      339      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ItsSudip ItsSudip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some negative test cases as well?

Copy link

sonarcloud bot commented Jun 18, 2024

@Vikas26021999 Vikas26021999 merged commit 60fee0e into develop Jun 18, 2024
17 checks passed
@Vikas26021999 Vikas26021999 deleted the feat.GARecordEvent branch June 18, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants