-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: garl record event support #3403
Conversation
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3403/test-report.html |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3403 +/- ##
===========================================
+ Coverage 88.03% 88.06% +0.02%
===========================================
Files 574 577 +3
Lines 31056 31150 +94
Branches 7410 7424 +14
===========================================
+ Hits 27340 27431 +91
+ Misses 3405 3380 -25
- Partials 311 339 +28 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add some negative test cases as well?
src/v0/destinations/google_adwords_remarketing_lists/transform.js
Outdated
Show resolved
Hide resolved
src/v0/destinations/google_adwords_remarketing_lists/transform.js
Outdated
Show resolved
Hide resolved
src/v0/destinations/google_adwords_remarketing_lists/transformV2.js
Outdated
Show resolved
Hide resolved
test/integrations/destinations/google_adwords_remarketing_lists/router/data.ts
Outdated
Show resolved
Hide resolved
src/v0/destinations/google_adwords_remarketing_lists/recordTransform.js
Outdated
Show resolved
Hide resolved
…nsform.js Co-authored-by: Sudip Paul <[email protected]>
src/v0/destinations/google_adwords_remarketing_lists/recordTransform.js
Outdated
Show resolved
Hide resolved
test/integrations/destinations/google_adwords_remarketing_lists/router/data.ts
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
What are the changes introduced in this PR?
record event changes for GARL
What is the related Linear task?
Resolves REV-1011
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.