Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: test case cleanup #3888

Merged
merged 2 commits into from
Nov 18, 2024
Merged

chore: test case cleanup #3888

merged 2 commits into from
Nov 18, 2024

Conversation

krishna2020
Copy link
Collaborator

@krishna2020 krishna2020 commented Nov 18, 2024

What are the changes introduced in this PR?

Updated test case with sample url's

What is the related Linear task?

Resolves INT-2925

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.47%. Comparing base (e90d2ad) to head (c2c2c8a).
Report is 12 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3888      +/-   ##
===========================================
+ Coverage    89.05%   90.47%   +1.41%     
===========================================
  Files          618      616       -2     
  Lines        33071    32309     -762     
  Branches      7814     7674     -140     
===========================================
- Hits         29452    29232     -220     
+ Misses        3336     2853     -483     
+ Partials       283      224      -59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krishna2020 krishna2020 merged commit 74fab0e into develop Nov 18, 2024
20 checks passed
@krishna2020 krishna2020 deleted the chore.testcase.cleanup branch November 18, 2024 08:50
Copy link

sonarcloud bot commented Nov 18, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants