add test for GetYamlFiles and fix a bug

Signed-off-by: Rumen Vasilev <[email protected]>

internal/util/io.go

@@ -178,13 +178,15 @@ func GetYamlFiles(dir string) ([]string, error) {
 	}
 
 	var sigs []string
-	var ext string
+	var ext, fullPath string
 	for _, f := range files {
-		ext = filepath.Ext(dir + "/" + f.Name())
-		if ext == "yml" || ext == "yaml" {
-			sigs = append(sigs, fmt.Sprintf("%s/%s", dir, f.Name()))
+		fullPath = fmt.Sprintf("%s/%s", dir, f.Name())
+		ext = filepath.Ext(fullPath)
+		if ext == ".yml" || ext == ".yaml" {
+			sigs = append(sigs, fullPath)
 		}
 	}
+
 	return sigs, nil
 }
 

internal/util/io_test.go

@@ -106,3 +106,27 @@ func BenchmarkIsBinaryFile(b *testing.B) {
 		IsBinaryFile("../../bin/rvsecret-darwin")
 	}
 }
+
+func TestGetYamlFiles(t *testing.T) {
+	t.Run("ok", func(t *testing.T) {
+		dir := "../../testfixtures/yamlfiles"
+		want := []string{dir + "/file-2.yml", dir + "/file1.yaml"}
+		got, err := GetYamlFiles(dir)
+		assert.NoError(t, err)
+		assert.Equal(t, want, got)
+	})
+
+	t.Run("no files found", func(t *testing.T) {
+		dir := "./"
+		got, err := GetYamlFiles(dir)
+		assert.NoError(t, err)
+		assert.Empty(t, got)
+	})
+
+	t.Run("err", func(t *testing.T) {
+		dir := "none/existing/dir"
+		got, err := GetYamlFiles(dir)
+		assert.Error(t, err)
+		assert.Empty(t, got)
+	})
+}

testfixtures/yamlfiles/file-2.yml

@@ -0,0 +1,5 @@
+--
+root:
+  node:
+    - list
+    - file2

testfixtures/yamlfiles/file1.yaml

@@ -0,0 +1,4 @@
+--
+root:
+  node:
+    - list

testfixtures/yamlfiles/notyaml.file

@@ -0,0 +1,4 @@
+--
+#this file is expected to be ignored
+root:
+  child: bla