Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve github pull request call retries #1810

Merged
merged 2 commits into from
Oct 4, 2021
Merged

Improve github pull request call retries #1810

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7174af4
Improve github pull request call retries
aristocrates Sep 15, 2021
32b0509
Fix style with gofmt -s
aristocrates Sep 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions server/events/vcs/github_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,10 +288,14 @@ func (g *GithubClient) GetPullRequest(repo models.Repo, num int) (*github.PullRe

// GitHub has started to return 404's here (#1019) even after they send the webhook.
// They've got some eventual consistency issues going on so we're just going
// to retry up to 3 times with a 1s sleep.
numRetries := 3
retryDelay := 1 * time.Second
for i := 0; i < numRetries; i++ {
// to attempt up to 5 times with exponential backoff.
maxAttempts := 5
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(first attempt technically isn't a retry so I changed the var names to use attempt)

attemptDelay := 0 * time.Second
for i := 0; i < maxAttempts; i++ {
// First don't sleep, then sleep 1, 3, 7, etc.
time.Sleep(attemptDelay)
attemptDelay = 2*attemptDelay + 1*time.Second

pull, _, err = g.client.PullRequests.Get(g.ctx, repo.Owner, repo.Name, num)
if err == nil {
return pull, nil
Expand All @@ -300,7 +304,6 @@ func (g *GithubClient) GetPullRequest(repo models.Repo, num int) (*github.PullRe
if !ok || ghErr.Response.StatusCode != 404 {
return pull, err
}
time.Sleep(retryDelay)
}
return pull, err
}
Expand Down