use stdin to send the password to ansible-vault command #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltamaster
changed the title
ltamaster
changed the title
gschueler
reviewed
Apr 5, 2024
src/main/groovy/com/rundeck/plugins/ansible/ansible/AnsibleVault.java
Outdated
Show resolved
Hide resolved
add unit test
src/main/groovy/com/rundeck/plugins/ansible/ansible/AnsibleVault.java
Outdated
Show resolved
Hide resolved
| @@ -26,19 +27,26 @@ public class AnsibleVault { | |||
|
|
|||
| public final String ANSIBLE_VAULT_COMMAND = "ansible-vault"; | |||
|
|
|||
| private ProcessExecutor.ProcessExecutorBuilder processExecutorBuilder; | |||
There was a problem hiding this comment.
Do we want this to be re-used across invocations of methods? Perhaps this should be an instance variable in each method? This appears to be an intentional change, just not sure why we need it. :)
There was a problem hiding this comment.
I just added that to mock it in the test
src/main/groovy/com/rundeck/plugins/ansible/ansible/AnsibleVault.java
Outdated
Show resolved
Hide resolved
src/main/groovy/com/rundeck/plugins/ansible/ansible/AnsibleVault.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use stdin to send the password to ansible-vault command