-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create proof trace event for tail call information #1179
Conversation
35e6e56
to
b4c6344
Compare
function exited with a tail call
39656e2
to
bdfceba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a couple low-level comments that I highlighted in the diff, but also one higher level comment: tail call info feels like a weird name for the event when it is emitted even in functions with no tail call. What if we just call it a function exit event?
…rule ordinals in function exit events
@dwightguth I addressed your comments. Could you take another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good but please double check what I commented on and fix it if my suspicions are correct.
This PR adds a new event that provides information on the way a function exits control, specifically whether it exits via a tail call or a conventional return statement. This event is added to assist in computing the call stack of the various simplifications from the proof trace hint.