Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove visual debugging tool on instance destruction? #128

Open
ivanbacher opened this issue Nov 4, 2021 · 0 comments
Open

Remove visual debugging tool on instance destruction? #128

ivanbacher opened this issue Nov 4, 2021 · 0 comments

Comments

@ivanbacher
Copy link
Contributor

ivanbacher commented Nov 4, 2021

Should the visual debugging tool also be removed when calling scroller.destory()?

Not that important, but maybe something to keep in mind for v3.

This is probably also more applicable when using single pages applications like vue, aurelia, svelte ....

Pretty simple to remove the visual debuggers at the moment, but one more thing to remember:

window.document.body
      .querySelectorAll('.scrollama__debug-step')
      .forEach(el => el.remove())
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants