Skip to content
This repository has been archived by the owner on Mar 14, 2023. It is now read-only.

Add reminder about review in welcome msg #418

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions highfive/newpr.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@
raw_welcome = """Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from %s soon.

Please see [the contribution instructions](%s) for more information.

Tip: when your PR is ready for review, don't forget to fire up the command `@rustbot ready` to put your PR in the review queue of your assigned reviewer: this will help speed up the overall review process.
"""

warning_summary = ':warning: **Warning** :warning:\n\n%s'
Expand Down
4 changes: 2 additions & 2 deletions highfive/tests/test_integration_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ def test_new_pr_non_contributor(self):
(
'POST', newpr.post_comment_url % ('rust-lang', 'rust', '7'),
{
'body': "Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nrc (or someone else) soon.\n\nPlease see [the contribution instructions](https://rustc-dev-guide.rust-lang.org/contributing.html) for more information.\n"}
'body': "Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nrc (or someone else) soon.\n\nPlease see [the contribution instructions](https://rustc-dev-guide.rust-lang.org/contributing.html) for more information.\n\nTip: when your PR is ready for review, don't forget to fire up the command `@rustbot ready` to put your PR in the review queue of your assigned reviewer: this will help speed up the overall review process.\n"}
),
{'body': {}},
),
Expand Down Expand Up @@ -145,7 +145,7 @@ def test_new_pr_empty_body(self):
(
'POST', newpr.post_comment_url % ('rust-lang', 'rust', '7'),
{
'body': "Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nrc (or someone else) soon.\n\nPlease see [the contribution instructions](https://rustc-dev-guide.rust-lang.org/contributing.html) for more information.\n"}
'body': "Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nrc (or someone else) soon.\n\nPlease see [the contribution instructions](https://rustc-dev-guide.rust-lang.org/contributing.html) for more information.\n\nTip: when your PR is ready for review, don't forget to fire up the command `@rustbot ready` to put your PR in the review queue of your assigned reviewer: this will help speed up the overall review process.\n"}
),
{'body': {}},
),
Expand Down
2 changes: 2 additions & 0 deletions highfive/tests/test_newpr.py
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,8 @@ def test_welcome_msg(self):
base_msg = """Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from %s soon.

Please see [the contribution instructions](%s) for more information.

Tip: when your PR is ready for review, don't forget to fire up the command `@rustbot ready` to put your PR in the review queue of your assigned reviewer: this will help speed up the overall review process.
"""

# No reviewer, no config contributing link.
Expand Down