Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize Docker caching on CI #103

Open
Kobzol opened this issue Feb 13, 2024 · 1 comment
Open

Optimize Docker caching on CI #103

Kobzol opened this issue Feb 13, 2024 · 1 comment
Labels
help wanted We would appreciate help from outside contributors.

Comments

@Kobzol
Copy link

Kobzol commented Feb 13, 2024

Currently, our GHA CI workflows on rust-lang/rust use a cached Docker build, which speeds up the workflow considerably. However, they still upload the resulting Docker image to the rust-lang-ci registry, even if there were no changes in the input Docker image. It would be nice to change that and avoid that needless upload in that case.

For reference, the caching was implemented in this PR: rust-lang/rust#119290.
@Kobzol Kobzol added the help wanted We would appreciate help from outside contributors. label Feb 13, 2024
@geektype
Copy link

As discussed, I'll have a look in to this over the weekend and submit a PR.

@geektype geektype mentioned this issue Feb 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted We would appreciate help from outside contributors.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Kobzol @geektype