Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privileges for the rustup repo #80

Closed
djc opened this issue Oct 4, 2023 · 7 comments · Fixed by rust-lang/team#1090
Closed

Privileges for the rustup repo #80

djc opened this issue Oct 4, 2023 · 7 comments · Fixed by rust-lang/team#1090

Comments

@djc
Copy link

djc commented Oct 4, 2023

The rustup team got some new members recently:

@rami3l and I were expecting to get maintainer-level privileges to the rustup repo after this, but that hasn't happened yet. Is that a policy or implementation issue?

cc @rbtcollins (as rustup lead)

@Kobzol
Copy link

Kobzol commented Oct 4, 2023

I think that the rustup repo isn't managed by automation yet (?), since it's not here.

@rami3l
Copy link
Member

rami3l commented Oct 4, 2023

I think that the rustup repo isn't managed by automation yet (?), since it's not here.

Is it appropriate to add a config there for rustup to be future-proof then? I'm willing to offer a PR if it's okay to do so.

@jdno
Copy link
Member

jdno commented Oct 4, 2023

I went ahead and created a pull request here.

@rbtcollins
Copy link

I don't see any reason for rustup to be a special case. Just needs someone familiar with things to perform whatever work is involved.

I'm not sure of what my personal access to the rustup repo is - I think I'm just 'Member' - I don't have Settings or security reports or other such things.

@jdno
Copy link
Member

jdno commented Oct 5, 2023

The pull request got merged and the rustup repository is now managed by rust-lang/team. A new team was created under our GitHub org with all members of the team, so whenever someone joins or leaves the permissions are automatically applied.

Hi, @rust-lang/rustup 👋 Let me know if there are any issues.

@djc
Copy link
Author

djc commented Oct 5, 2023

Very nice! Would it be possible to set up the merge queue on the repo, and if so, how do we go about that? And is it possible to rename the master branch to main within your current setup? (That's just me asking, not discussed with other team members yet.)

@jdno
Copy link
Member

jdno commented Oct 5, 2023

I think neither of those are possible through the team repo yet, but we can for sure help you with that if you'd like. Probably easiest to ask in #t-infra on Zulip once you've discussed it with the team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants