Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctest: change API of when to skip #4122

Open
tgross35 opened this issue Nov 20, 2024 · 1 comment
Open

ctest: change API of when to skip #4122

tgross35 opened this issue Nov 20, 2024 · 1 comment

Comments

@tgross35
Copy link
Contributor

Currently our config looks a bit like this:

    cfg.skip_field(move |struct_, field| {
        (struct_ == "siginfo_t" && field == "_pad") ||
        (musl && struct_ == "glob_t" && field == "gl_flags") ||
        // ...
    });

A problem is that we have no validation that e.g. _pad actually exists in siginfo_t. It would be better to have something like the following:

cfg.skip_field(&[
    // format: `(struct, field, extra_condition)`
    ("siginfo_t", "_pad", true),
    ("glob_t", "gl_flags", musl),
])

This would skip if any any of the entries match struct and field, and the condition for that row is true. However, it could also warn if any of those items are never used meaning the struct or field don't exist.

@tgross35
Copy link
Contributor Author

For the ctest rewrite it would also be nice to be able to specify volatile_item with an annotation rather than in the build script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant