run Miri tests on CI #411
Merged
run Miri tests on CI #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like CI is broken on latest nightly. (Pinning the nightly instead of always using the latest would avoid that. Works pretty well for us in Miri. :) |
|
Looks good to me, thanks! I think you're right, I should pin the nightly version. |
I had not done this part yet, so this will probably be by far the slowest CI job now. I just can't test that when CI is broken.
FWIW in Miri we also have
|
|
This probably just needs a rustc-pull to fix CI, as the renames have been already handled in the rustc repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically the portable-simd version of rust-lang/rust#123506. Miri supports all the intrinsics now (as far as I know) and this would let us catch regressions before they enter the tree, rather having to chase them when https://github.com/rust-lang/miri-test-libstd/ fails.
If you add/change an intrinsic in the future, there are several options -- do the Miri support together with the codegen support (which anyway has to land before anything can land here), or temporarily disable some tests under Miri, or temporarily disable Miri entirely. I'll leave that to you. I hope this will be fairly rare. :)
Just enabling Miri will likely be too slow, this takes ~45 minutes. I think I'll move the 4-lane tests to
cfg(not(miri)), there's not really any point in testing many different lane counts as Miri implements those as just a loop anyway.