-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fill in HIR hash for associated opaque types #122517
Conversation
@bors p=1 |
@bors p=2 |
@bors p=15 |
Fill in HIR hash for associated opaque types Fixes rust-lang#122508
The job Click to see the possible cause of the failure (guessed by this bot)
|
💔 Test failed - checks-actions |
@bors retry The runner has received a shutdown signal |
☀️ Test successful - checks-actions |
Finished benchmarking commit (ee03c28): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 671.201s -> 669.125s (-0.31%) |
@@ -642,23 +642,8 @@ impl<'a, 'hir> LoweringContext<'a, 'hir> { | |||
let bodies = SortedMap::from_presorted_elements(bodies); | |||
|
|||
// Don't hash unless necessary, because it's expensive. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this comment is leftover but now belongs in hash_owner_nodes
#122396 | Try | 918ae71 | Finished | 3/15/2024, 2:42:19 PM | 1h 10m 14s | Strange fluke in time for perf run time for this pr (currently from https://perf.rust-lang.org/status.html)
|
Fixes #122508