[crater only] make forbidden_lint_groups a hard error

[RalfJung]

This is to gather information for #81670.

[rustbot]

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[RalfJung]

@bors try

[bors]

⌛ Trying commit b20df8f with merge 31561a6...

[rust-log-analyzer]

The job x86_64-gnu-llvm-18 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

#16 exporting to docker image format
#16 sending tarball 27.1s done
#16 DONE 33.2s
##[endgroup]
Setting extra environment values for docker:  --env ENABLE_GCC_CODEGEN=1 --env GCC_EXEC_PREFIX=/usr/lib/gcc/
[CI_JOB_NAME=x86_64-gnu-llvm-18]
debug: `DISABLE_CI_RUSTC_IF_INCOMPATIBLE` configured.
---
sccache: Starting the server...
##[group]Configure the build
configure: processing command line
configure: 
configure: build.configure-args := ['--build=x86_64-unknown-linux-gnu', '--llvm-root=/usr/lib/llvm-18', '--enable-llvm-link-shared', '--set', 'rust.randomize-layout=true', '--set', 'rust.thin-lto-import-instr-limit=10', '--enable-verbose-configure', '--enable-sccache', '--disable-manage-submodules', '--enable-locked-deps', '--enable-cargo-native-static', '--set', 'rust.codegen-units-std=1', '--set', 'dist.compression-profile=balanced', '--dist-compression-formats=xz', '--set', 'rust.lld=false', '--disable-dist-src', '--release-channel=nightly', '--enable-debug-assertions', '--enable-overflow-checks', '--enable-llvm-assertions', '--set', 'rust.verify-llvm-ir', '--set', 'rust.codegen-backends=llvm,cranelift,gcc', '--set', 'llvm.static-libstdcpp', '--enable-new-symbol-mangling']
configure: target.x86_64-unknown-linux-gnu.llvm-config := /usr/lib/llvm-18/bin/llvm-config
configure: llvm.link-shared     := True
configure: rust.randomize-layout := True
configure: rust.thin-lto-import-instr-limit := 10
---

failures:

---- [ui] tests/ui/lint/forbid-group-group-2.rs stdout ----
Saved the actual stderr to "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/forbid-group-group-2/forbid-group-group-2.stderr"

- error: allow(nonstandard_style) incompatible with previous forbid
+ error[E0453]: allow(nonstandard_style) incompatible with previous forbid
2   --> $DIR/forbid-group-group-2.rs:7:9
2   --> $DIR/forbid-group-group-2.rs:7:9
3    |
4 LL | #![forbid(warnings)]
6 ...
7 LL | #[allow(nonstandard_style)]
8    |         ^^^^^^^^^^^^^^^^^ overruled by previous forbid
-    |
---
- error: allow(nonstandard_style) incompatible with previous forbid
+ error[E0453]: allow(nonstandard_style) incompatible with previous forbid
19   --> $DIR/forbid-group-group-2.rs:7:9
20    |
21 LL | #![forbid(warnings)]
24 LL | #[allow(nonstandard_style)]
25    |         ^^^^^^^^^^^^^^^^^ overruled by previous forbid
26    |
-    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
-    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
-    = note: for more information, see issue #81670 <https://github.com/rust-lang/rust/issues/81670>
29    = note: duplicate diagnostic emitted due to `-Z deduplicate-diagnostics=no`
- error: allow(nonstandard_style) incompatible with previous forbid
+ error[E0453]: allow(nonstandard_style) incompatible with previous forbid
32   --> $DIR/forbid-group-group-2.rs:7:9
33    |
33    |
34 LL | #![forbid(warnings)]
37 LL | #[allow(nonstandard_style)]
38    |         ^^^^^^^^^^^^^^^^^ overruled by previous forbid
39    |
-    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
-    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
-    = note: for more information, see issue #81670 <https://github.com/rust-lang/rust/issues/81670>
42    = note: duplicate diagnostic emitted due to `-Z deduplicate-diagnostics=no`
44 error: aborting due to 3 previous errors

45 
+ For more information about this error, try `rustc --explain E0453`.
---
To only update this specific test, also pass `--test-args lint/forbid-group-group-2.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/lint/forbid-group-group-2.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=x86_64-unknown-linux-gnu" "--check-cfg" "cfg(FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/forbid-group-group-2" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers"
--- stderr -------------------------------
error[E0453]: allow(nonstandard_style) incompatible with previous forbid
##[error]  --> /checkout/tests/ui/lint/forbid-group-group-2.rs:7:9
   |
   |
LL | #![forbid(warnings)]
   |           -------- `forbid` level set here
LL | #[allow(nonstandard_style)]
   |         ^^^^^^^^^^^^^^^^^ overruled by previous forbid

error[E0453]: allow(nonstandard_style) incompatible with previous forbid
error[E0453]: allow(nonstandard_style) incompatible with previous forbid
##[error]  --> /checkout/tests/ui/lint/forbid-group-group-2.rs:7:9
   |
LL | #![forbid(warnings)]
   |           -------- `forbid` level set here
LL | #[allow(nonstandard_style)]
   |         ^^^^^^^^^^^^^^^^^ overruled by previous forbid
   |
   |
   = note: duplicate diagnostic emitted due to `-Z deduplicate-diagnostics=no`
error[E0453]: allow(nonstandard_style) incompatible with previous forbid
##[error]  --> /checkout/tests/ui/lint/forbid-group-group-2.rs:7:9
   |
   |
LL | #![forbid(warnings)]
   |           -------- `forbid` level set here
LL | #[allow(nonstandard_style)]
   |         ^^^^^^^^^^^^^^^^^ overruled by previous forbid
   |
   |
   = note: duplicate diagnostic emitted due to `-Z deduplicate-diagnostics=no`
error: aborting due to 3 previous errors

For more information about this error, try `rustc --explain E0453`.
------------------------------------------
------------------------------------------


---- [ui] tests/ui/lint/forbid-group-member.rs stdout ----

error: test compilation failed although it shouldn't!
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/lint/forbid-group-member.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=x86_64-unknown-linux-gnu" "--check-cfg" "cfg(FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/forbid-group-member" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers"
--- stderr -------------------------------
error[E0453]: allow(unused_variables) incompatible with previous forbid
##[error]  --> /checkout/tests/ui/lint/forbid-group-member.rs:8:9
   |
   |
LL | #![forbid(unused)]
   |           ------ `forbid` level set here
LL | #[allow(unused_variables)]
   |         ^^^^^^^^^^^^^^^^ overruled by previous forbid

error: aborting due to 1 previous error
---
- error: warn(unused) incompatible with previous forbid
+ error[E0453]: warn(unused) incompatible with previous forbid
2   --> $DIR/issue-70819-dont-override-forbid-in-same-scope.rs:22:13
3    |
4 LL |     #![forbid(unused)]
6 LL |     #![deny(unused)]
7 LL |     #![warn(unused)]
8    |             ^^^^^^ overruled by previous forbid
-    |
-    |
-    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
-    = note: for more information, see issue #81670 <https://github.com/rust-lang/rust/issues/81670>
- note: the lint level is defined here
-   --> $DIR/issue-70819-dont-override-forbid-in-same-scope.rs:17:11
-    |
- LL | #![forbid(forbidden_lint_groups)]
17 
18 error: aborting due to 1 previous error
19 

---
To only update this specific test, also pass `--test-args lint/issue-70819-dont-override-forbid-in-same-scope.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/lint/issue-70819-dont-override-forbid-in-same-scope.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=x86_64-unknown-linux-gnu" "--check-cfg" "cfg(FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/issue-70819-dont-override-forbid-in-same-scope" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Z" "deduplicate-diagnostics=yes"
--- stderr -------------------------------
error[E0453]: warn(unused) incompatible with previous forbid
##[error]  --> /checkout/tests/ui/lint/issue-70819-dont-override-forbid-in-same-scope.rs:22:13
   |
   |
LL |     #![forbid(unused)]
   |               ------ `forbid` level set here
LL |     #![warn(unused)]
   |             ^^^^^^ overruled by previous forbid

error: aborting due to 1 previous error
---
- error: allow(unused_variables) incompatible with previous forbid
+ error[E0453]: allow(unused_variables) incompatible with previous forbid
2   --> $DIR/outer-forbid.rs:20:9
3    |
4 LL | #![forbid(unused, non_snake_case)]
6 ...
7 LL | #[allow(unused_variables)]
8    |         ^^^^^^^^^^^^^^^^ overruled by previous forbid
-    |
-    |
-    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
-    = note: for more information, see issue #81670 <https://github.com/rust-lang/rust/issues/81670>
- note: the lint level is defined here
-   --> $DIR/outer-forbid.rs:18:11
-    |
- LL | #![forbid(forbidden_lint_groups)]
17 
- error: allow(unused) incompatible with previous forbid
+ error[E0453]: allow(unused) incompatible with previous forbid
19   --> $DIR/outer-forbid.rs:25:9
19   --> $DIR/outer-forbid.rs:25:9
20    |
21 LL | #![forbid(unused, non_snake_case)]
23 ...
24 LL | #[allow(unused)]
25    |         ^^^^^^ overruled by previous forbid
-    |
---
To only update this specific test, also pass `--test-args lint/outer-forbid.rs`

error: 1 errors occurred comparing output.
status: exit status: 1
command: env -u RUSTC_LOG_COLOR RUSTC_ICE="0" RUST_BACKTRACE="short" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/lint/outer-forbid.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "-Z" "ignore-directory-in-diagnostics-source-blocks=/cargo" "-Z" "ignore-directory-in-diagnostics-source-blocks=/checkout/vendor" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=x86_64-unknown-linux-gnu" "--check-cfg" "cfg(FALSE)" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Zwrite-long-types-to-disk=no" "-Cstrip=debuginfo" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/outer-forbid" "-A" "unused" "-A" "internal_features" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-Z" "deduplicate-diagnostics=yes"
--- stderr -------------------------------
error[E0453]: allow(unused_variables) incompatible with previous forbid
##[error]  --> /checkout/tests/ui/lint/outer-forbid.rs:20:9
   |
   |
LL | #![forbid(unused, non_snake_case)]
   |           ------ `forbid` level set here
LL | #[allow(unused_variables)]
   |         ^^^^^^^^^^^^^^^^ overruled by previous forbid

error[E0453]: allow(unused) incompatible with previous forbid
error[E0453]: allow(unused) incompatible with previous forbid
##[error]  --> /checkout/tests/ui/lint/outer-forbid.rs:25:9
   |
LL | #![forbid(unused, non_snake_case)]
   |           ------ `forbid` level set here
...
LL | #[allow(unused)] //~ ERROR incompatible with previous

error[E0453]: allow(nonstandard_style) incompatible with previous forbid
##[error]  --> /checkout/tests/ui/lint/outer-forbid.rs:29:9
   |
   |
LL | #![forbid(unused, non_snake_case)]
   |                   -------------- `forbid` level set here
...
LL | #[allow(nonstandard_style)] //~ ERROR incompatible with previous

error: aborting due to 3 previous errors

For more information about this error, try `rustc --explain E0453`.

[bors]

☀️ Try build successful - checks-actions
Build commit: 31561a6 (31561a63598a0f21fc74c024747ef1310fdd2eb2)

[RalfJung]

@craterbot check

[craterbot]

👌 Experiment pr-133536 created and queued.
🤖 Automatically detected try build 31561a6
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[craterbot]

🚧 Experiment pr-133536 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[compiler-errors]

@craterbot cancel

Crater is currently bugging out and running at 155% completed on another job. I'm gonna clear the queue and re-queue all the jobs in order.

[craterbot]

🗑️ Experiment pr-133536 deleted!

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[compiler-errors]

Re-queueing now :)

@craterbot check

[craterbot]

👌 Experiment pr-133536 created and queued.
🤖 Automatically detected try build 31561a6
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[craterbot]

🚧 Experiment pr-133536 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more